mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2026-02-17 22:05:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

protocol: remove note discouraging use of wl_surface.damage

Browse source 
If a client tracks damage in surface coordinates, there is no reason for
it to use the damage_buffer request.

The message of the commit that originally added this note says that the
compositor might implement wl_surface.damage inefficiently and that it
is complicated to implement correctly. Having the logic replicated in
every client that tracks damage in surface coordinates does not make it
more efficient or more correct. The conversion between surface and
buffer damage can be implemented as a matrix multiplication but it's not
easy to get right and it is more likely that compositors will have a
correct and fast implementation.

Reverts: 921d054803
Signed-off-by: Julian Orth <ju.orth@gmail.com>
This commit is contained in:
Julian Orth 2025-12-11 22:48:21 +01:00
parent bbb5fa66a7
commit eac3fd97e9
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
protocol/wayland.xml
View file

@ -1572,10 +1572,6 @@
wl_surface.commit assigns pending damage as the current damage,
and clears pending damage. The server will clear the current
damage as it repaints the surface.
Note! New clients should not use this request. Instead damage can be
posted with wl_surface.damage_buffer which uses buffer coordinates
instead of surface coordinates.
</description>
<arg name="x" type="int" summary="surface-local x coordinate"/>
<arg name="y" type="int" summary="surface-local y coordinate"/>