Commit graph

2567 commits

Author SHA1 Message Date
Nick Parker
6816253110 Fix segfault if swaybg is run without Wayland
Mirrors a similar check in `swaylock/main.c`
2018-02-19 15:04:51 -08:00
Drew DeVault
ddc8000384
Merge pull request #1592 from dlrobertson/fix_mem_errors
Fix more leaks
2018-02-11 15:53:13 -05:00
Dan Robertson
15f9c89e84
Fix more leaks
- get_parent_pid: free buffer returned from read_line after use.
 - workspace_for_pid: ensure free_pid_workspace is called when
   pid_workspaces are removed from config->pid_workspaces.
 - cmd_split: return the cmd_results from _do_split, so that the
   parent function may free it.
2018-02-11 20:45:06 +00:00
Drew DeVault
4a76d06f33
Merge pull request #1591 from dlrobertson/fix_mem_errors
Fix memory errors
2018-02-11 11:37:06 -05:00
Dan Robertson
aa15629f17
Fix memory errors
- read_line: OOB write when a line in /proc/modules contains a
   terminating character at size position.
 - handle_view_created: Ensure that the list_t returned by criteria_for
   is free'd after use
 - ipc_event_binding_keyboard/ipc_event_binding: Properly handle
   json_object reference counting and ownership.
2018-02-11 04:57:54 +00:00
Drew DeVault
a571506d0e
Merge pull request #1584 from 4e554c4c/no_more_hups
Handle swaybar status line errors
2018-02-05 18:11:07 -05:00
Calvin Lee
a83bca6db5 Handle swaybar status line errors
The event loop API was redesigned to avoid race conditions as well.
Fixes #1583
2018-02-04 12:31:07 -07:00
Drew DeVault
6ffcb031f9
Merge pull request #1579 from tmccombs/patch-1
Add description of clipboard command to man page
2018-01-29 16:17:04 -05:00
Thayne McCombs
12f6dfec2e
Add description of clipboard command to man page 2018-01-27 01:03:52 -07:00
Drew DeVault
fab88cd96a
Merge pull request #1563 from nearffxx/0.15
Fix out of focus when using mouse to change workspace
2018-01-21 12:18:48 -05:00
Drew DeVault
0ff89cf0d1
Merge pull request #1564 from pvsr/0.15
Calculate positions of empty blocks in swaybar
2018-01-13 09:17:54 -05:00
Peter Rice
efe5a6fc0a Calculate positions of empty blocks in swaybar 2018-01-12 23:12:23 -05:00
Chengyu Zheng
89188cf2b5 Fix out of focus when using mouse to change workspace
by preventing focus to C_OUTPUT when WLC_BUTTON_STATE_RELEASED event occurs.
2018-01-10 17:30:48 +01:00
Drew DeVault
3e3014df4d
Merge pull request #1561 from pvsr/0.15
Handle forward/back mouse buttons in swaybar
2018-01-08 09:18:46 -05:00
Peter Rice
e2d54d36d2 Handle forward/back mouse buttons in swaybar 2018-01-07 19:27:34 -05:00
Drew DeVault
c6d54f364f
Merge pull request #1559 from 4e554c4c/invalid_free
Prevent invalid free of workspace name
2018-01-06 21:55:06 -05:00
Calvin Lee
be39e84875 Prevent invalid free of workspace name
An allocated pointer was incremented before being freed in
`sway/workspace.c` which led to an invalid free. This has been fixed by
keeping the pointer in place and moving the data instead.

Fixes #1548
2018-01-06 19:20:29 -07:00
Drew DeVault
a74d1a1992
Merge pull request #1516 from AGausmann/issue-1507
Patch #1507: Clicking on invisible title bars switches focus
2018-01-05 09:20:19 -05:00
Drew DeVault
1e87c90923
Merge pull request #1431 from 4e554c4c/sni_sucks
Support libappindicator
2017-12-29 14:24:23 -05:00
gnidorah
4d34bc393e Keep tray separate 2017-12-29 12:11:51 -07:00
gnidorah
87a55dfe5c Fix icon updating on secondary outputs 2017-12-29 12:11:51 -07:00
gnidorah
cbd0c49a8c Allow correct item to get icon updates for both kde and gtk implementation 2017-12-29 12:11:51 -07:00
Calvin Lee
13b81f9fb9 Fix get_icon
Property reply functions are now notified if there was an error with the
property instead of silent failure. Also issues in `get_item` were
resolved.
2017-12-29 12:11:51 -07:00
Calvin Lee
87035380e3 Add dbus_get_prop_async utility
This drastically reduces the amount of boilerplate needed to get a
property from a bus object.
2017-12-29 12:11:51 -07:00
Calvin Lee
b9f36716b5 Plug memory dbus_message_iter_get_signature leak 2017-12-29 12:11:51 -07:00
Calvin Lee
5c8dc9cb73 Correct context menu placement if bar is bottom
Originally the context menu would draw at the top of the screen, which
is incorrect.
2017-12-29 12:11:51 -07:00
gnidorah
2f1eb30c38 Reply in case of object path item 2017-12-29 12:11:51 -07:00
Calvin Lee
3137f32711 Allow correct item to get icon updates 2017-12-29 12:11:51 -07:00
Calvin Lee
210e5bb893 Improve Icon Theme Implimentation 2017-12-29 12:11:51 -07:00
Calvin Lee
5bc46f458c Prevent segfault in get_items()
One segfault resulted from an incorrect dbus call in sni_watcher. The
other from duplicate items in the sni host.
2017-12-29 12:11:51 -07:00
Calvin Lee
4231061e4d Allow multiple object paths for each connection 2017-12-29 12:11:51 -07:00
gnidorah
bd121999ca Allow paths to icons in iconName property 2017-12-29 12:11:51 -07:00
Calvin Lee
ad99d9dff8 Allow registering StatusNotifierItems by obj path
This commit impliments a KDE hidden feature where a SNI could be
registered by object path instead of well-known name. This should allow
libappindicator programs to work correctly under sway.

See #1372
2017-12-29 12:11:51 -07:00
Drew DeVault
d85ad05fa8
Merge pull request #1544 from CedricCabessa/fix1056-swaylock-allow-popup-to-come-through
partial fix #1056
2017-12-29 13:55:38 -05:00
Cédric Cabessa
d6cc6600d0 partial fix #1056
this patch allow the user to type its password when a modal window is shown
while the desktop is locked by swaylock.
It is a partial fix of the bug since the window should be visible (see bug
https://github.com/swaywm/sway/issues/1056 for details).
2017-12-29 18:03:02 +01:00
Björn Esser
c08c805ecd Adaptions for API change in json-c v0.13
Lift restriction on json-c <= 0.12.1

ipc-server: Acquire ownership of referenced json_object properly

When adding a referenced json_object with an unknown lifetime to
another json_object, it must be done with a wrapped call to
json_object_get() to acquire the ownership of that json_object.
2017-12-17 15:53:22 -05:00
Drew DeVault
d0bd0ed598 Revert "Merge remote-tracking branch 'besser82/bugfix/json-c' into 0.15"
This reverts commit 1c4a086e75, reversing
changes made to 1263ea6497.
2017-12-17 15:52:34 -05:00
Drew DeVault
1c4a086e75 Merge remote-tracking branch 'besser82/bugfix/json-c' into 0.15 2017-12-17 15:51:49 -05:00
Drew DeVault
1263ea6497
Merge pull request #1519 from ggreer/clear-password-buffer-0.15
Swaylock: Clear password buffer after use.
2017-12-16 21:12:36 -05:00
Adam Gausmann
6cd66286f2 Tabs got broken, fixed visibility check 2017-12-14 21:57:02 -06:00
Adam Gausmann
0f1ca2a5d3 Fix windows being focused when invisible 2017-12-14 21:57:02 -06:00
Geoff Greer
1312db8b43 Swaylock: Clear password buffer after use.
After a user enters or clears a password, try to overwrite the buffer containing it. That way it's not sitting around in RAM for something else to read later. Also, mlock() the password buffer so that it is never swapped out.

This also replaces the dynamically allocated buffer with a static char[1024]. Any characters past that are discarded until the user hits enter or escape.
2017-12-14 19:53:11 -08:00
Drew DeVault
af25e8ca90
Merge pull request #1515 from 4e554c4c/holds_up_fork
Fix `swaylock -f`
2017-12-14 15:38:52 -05:00
Björn Esser
02da9c4e7c
Adaptions for API change in json-c v0.13 2017-12-14 18:47:24 +01:00
Björn Esser
8272a9bae0
ipc-server: Acquire ownership of referenced json_object properly
When adding a referenced json_object with an unknown lifetime to
another json_object, it must be done with a wrapped call to
json_object_get() to acquire the ownership of that json_object.
2017-12-14 18:47:22 +01:00
Björn Esser
c6e12368a5
Lift restriction on json-c <= 0.12.1 2017-12-14 16:43:21 +01:00
Calvin Lee
609430053b Fix swaylock -f
This commit makes swaylock poll the registry the first time in its
fork in order for sway to recognize it and grant it lock privileges
2017-12-13 16:47:53 -07:00
Drew DeVault
52c4c166d8 Merge pull request #1446 from kon14/patch-1
Update README.el.md
2017-11-06 18:16:22 -05:00
Drew DeVault
5a150d5317 Merge pull request #1445 from yuilib/update-readme-ja
Update README.ja.md
2017-11-06 18:16:19 -05:00
Drew DeVault
37a4b62625 Merge pull request #1455 from etam/dbus_dependency
Update dbus dependency
2017-11-06 18:16:07 -05:00