raop: Fix potential NULL dereference

'realm' is mandatory

Signed-off-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
This commit is contained in:
Peter Meerwald-Stadler 2017-03-01 20:37:06 +01:00
parent 233cb4516a
commit 0cb72beace

View file

@ -1259,13 +1259,13 @@ static void rtsp_auth_cb(pa_rtsp_client *rtsp, pa_rtsp_state_t state, pa_rtsp_st
pa_xfree(token); pa_xfree(token);
} }
if (pa_safe_streq(mth, "Basic")) { if (pa_safe_streq(mth, "Basic") && realm) {
rtrim_char(realm, '\"'); rtrim_char(realm, '\"');
pa_raop_basic_response(DEFAULT_USER_NAME, c->password, &response); pa_raop_basic_response(DEFAULT_USER_NAME, c->password, &response);
ath = pa_sprintf_malloc("Basic %s", ath = pa_sprintf_malloc("Basic %s",
response); response);
} else if (pa_safe_streq(mth, "Digest")) { } else if (pa_safe_streq(mth, "Digest") && realm && nonce) {
rtrim_char(realm, '\"'); rtrim_char(realm, '\"');
rtrim_char(nonce, '\"'); rtrim_char(nonce, '\"');