From 0cb72beaceca1e8e8e3eb330cbaa516912fa6dbd Mon Sep 17 00:00:00 2001 From: Peter Meerwald-Stadler Date: Wed, 1 Mar 2017 20:37:06 +0100 Subject: [PATCH] raop: Fix potential NULL dereference 'realm' is mandatory Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 9181e81bb..1bd4c4a02 100644 --- a/src/modules/raop/raop-client.c +++ b/src/modules/raop/raop-client.c @@ -1259,13 +1259,13 @@ static void rtsp_auth_cb(pa_rtsp_client *rtsp, pa_rtsp_state_t state, pa_rtsp_st pa_xfree(token); } - if (pa_safe_streq(mth, "Basic")) { + if (pa_safe_streq(mth, "Basic") && realm) { rtrim_char(realm, '\"'); pa_raop_basic_response(DEFAULT_USER_NAME, c->password, &response); ath = pa_sprintf_malloc("Basic %s", response); - } else if (pa_safe_streq(mth, "Digest")) { + } else if (pa_safe_streq(mth, "Digest") && realm && nonce) { rtrim_char(realm, '\"'); rtrim_char(nonce, '\"');