Commit graph

10800 commits

Author SHA1 Message Date
Wim Taymans
957470bd9f doc: add more docs 2023-05-16 16:15:54 +02:00
Wim Taymans
f5a65a27b0 docs: document some more 2023-05-16 15:44:22 +02:00
Wim Taymans
4eb64f5a6c doc: improve formatting 2023-05-16 12:55:48 +02:00
Wim Taymans
b5224a6844 doc: improve formatting 2023-05-16 12:50:18 +02:00
Wim Taymans
d7315ee572 docs: add more docs 2023-05-16 12:42:36 +02:00
Wim Taymans
56f3d0d417 docs: document some more 2023-05-16 12:27:05 +02:00
Wim Taymans
e759a2feed doc: document registry events and methods 2023-05-16 11:21:03 +02:00
Wim Taymans
aad69d22c1 doc: add more docs 2023-05-16 11:01:54 +02:00
Wim Taymans
736e9cc94c null-audio-sink: make it possible to override node.driver
See #3220
2023-05-15 21:25:28 +02:00
Wim Taymans
26e9a4ce13 impl-node: add some comments 2023-05-15 15:42:37 +02:00
Wim Taymans
f996249fff man: update man page some more
Add some more mentions that modules can not be loaded in a remote
instance in PipeWire.

Also mention the special internal remote name to connect to the local
pw-cli instance.

Fixes #2988
2023-05-15 13:31:13 +02:00
Wim Taymans
a0304c6691 module-rtp: sync session unlink with data thread
See #3217
2023-05-15 12:47:37 +02:00
Wim Taymans
a15517851e module-rtp: fix sess.media usage 2023-05-15 12:34:56 +02:00
Wim Taymans
d3896d290e module-rtp: set default sess.media in properties
Set a default sess.media in properties because we will use it later.
2023-05-15 12:23:28 +02:00
Wim Taymans
fb5c9688a2 doc: fix comment 2023-05-15 12:04:06 +02:00
Wim Taymans
a9d6807ec1 doc: add some more docs 2023-05-15 11:44:41 +02:00
Wim Taymans
9035b97b62 module-rt: improve messages
Move some warnings to info.
Only show 1 warning with all the info why module-rt can't provide
realtime scheduling.

Fixes #3194
2023-05-15 09:31:33 +02:00
Wim Taymans
988fc9692a impl-link: only activate links between runnable nodes
The node might be active but passive, in which case it will not run and
there is no need to schedule it.

Fixes #3215
2023-05-14 20:55:38 +02:00
Wim Taymans
a25c021074 jack: don't fill aliases by default
JACK does not automatically generate aliases, so don't do that either.

The problem is that no new ports can be created if one already exists
with the same name or any of the aliases. This causes problems when a
port is renamed and a new port is created with the old name because the
alias might still be the old name and port creation fails.

Add a jack.fill-aliases for this purpose.

Fixes #3154
2023-05-12 17:58:07 +02:00
Wim Taymans
4c48c7e7b9 module-roc-source: make sure we don't overflow target_latency
See #2641
2023-05-12 16:51:49 +02:00
Wim Taymans
bd28637233 module-rtp-sap: ttl is uint32_t 2023-05-12 16:37:25 +02:00
Sebastian Jaeckel
01d6724819 rtp-sink: fix ttl property which is NOT a bool 2023-05-12 14:34:17 +00:00
Wim Taymans
b3eb4518cb jack: only emit register notify in pairs
Only emit Off when On was sent.
2023-05-12 15:30:44 +02:00
Wim Taymans
8b18cbdce1 jack: restore previous global thread_utils
When a jack client is opened, the thread_utils from the context are
stored globaly. Replace this with a generic thread_utils when we close
the client again to avoid referencing freed memory.
2023-05-12 13:30:32 +02:00
Wim Taymans
741037f1ae impl-node: move signalfd into pw_node_target
We don't need an extra signal_func, we can write to the signalfd
directly.
2023-05-12 13:02:47 +02:00
Wim Taymans
e3d715dfdf module-raop: only send volume when recording
See #3210
2023-05-12 10:48:40 +02:00
Wim Taymans
3a08510a81 properties: fix serialization of values
When the first parsed part of the value does not look like a container,
dump the complete length of the value.

If a value would contain 'Tunnel sink', it would previously only
serialize the 'Tunnel' part and ignore the rest.

See #3212
2023-05-12 10:11:41 +02:00
Wim Taymans
7b0c019a2b pulse-server: include rate/format for tunnel 2023-05-12 10:11:17 +02:00
Wim Taymans
7eeb9a63f8 pulse-server: remove / when no target object 2023-05-12 10:11:01 +02:00
Wim Taymans
150e7031ae pulse-server: improve channel formatting 2023-05-12 10:09:42 +02:00
Wim Taymans
41ec84185f jack: make a real notify queue
Use a ringbuffer to store notify events. Emit them when no method is
running.

See #3183
2023-05-11 18:28:03 +02:00
Wim Taymans
5d5576f4a8 spa: make latency struct to compare const 2023-05-11 18:28:03 +02:00
Barnabás Pőcze
2ba9881b4d pulse-server: pending-sample: handle client disconnection correctly
Previously, a client disconnecting while a sample was playing could
lead to issues. For example, if a client disconnected before the
"ready" signal of the sample-play arrives, `operation_new_cb()`
would be called and that would try to use the client's pw_manager,
however, that has previously been destroyed in `client_disconnect()`.

If the client disconnected after the "ready" signal but before the reply
has been sent, then `sample_play_ready_reply()` would never be called
since operations are completed via the client's pw_manager which
would already be destroyed at that point.

Fix this by installing a listener on the client, and properly
cancelling the operation and making sure that the pending_sample
is correctly destroyed.
2023-05-10 18:57:20 +00:00
Barnabás Pőcze
bd510bf602 pulse-server: pending-sample: add on_ prefix to event handlers 2023-05-10 18:57:20 +00:00
Barnabás Pőcze
0395424461 pulse-server: add operation_free_by_tag() 2023-05-10 18:57:20 +00:00
Barnabás Pőcze
dd5f0e6bea pulse-server: pending-sample: only start operation if not replied already 2023-05-10 18:57:20 +00:00
Barnabás Pőcze
c25b6c973e pulse-server: pending-sample: factor out freeing logic 2023-05-10 18:57:20 +00:00
Barnabás Pőcze
cc702dac69 pulse-server: pending-sample: only send reply once 2023-05-10 18:57:20 +00:00
Barnabás Pőcze
edad053911 pulse-server: pending-sample: set replied flag on error
Set the `pending_sample::replied` flag when an error reply
is sent to the client.
2023-05-10 18:57:20 +00:00
Barnabás Pőcze
dd7c47bb3d pulse-server: pending-sample: rename ready to replied
Rename `pending_sample::ready` to `pending_sample::replied` because
it is set when a reply is sent, not when the ready signal comes.
2023-05-10 18:57:20 +00:00
Barnabás Pőcze
e37da42632 pulse-server: move sample playing into pending-sample.c 2023-05-10 18:57:20 +00:00
Sebastian Jaeckel
20d00e1092 aes67: adapt aes67 default config file to use the rtp-sap module 2023-05-10 17:40:30 +00:00
Sebastian Jaeckel
3ec0e1499f rtp-sap: use correct audio format string for L24 mime 2023-05-10 17:40:30 +00:00
Sebastian Jaeckel
44feba4bb4 rtp-sap: decrement session counter when a session is freed 2023-05-10 17:40:30 +00:00
Wim Taymans
4353f9eb75 module-jack: make stream ports physical
Just like the ports we connect to.
2023-05-10 18:00:44 +02:00
Wim Taymans
36fdceef71 jack: don't emit portregistration when inactive
Remove the port complete when the client is inactive. Otherwise we might
get a portregistration Off the next time the client is activated.
2023-05-10 17:22:43 +02:00
Wim Taymans
67fcd9646d impl-node: optimize peer activation
Before this patch, every link between node A and B would increment the
activation counter of B and add a new target to A. If there are N links
between A and B, resuming node A would then do N decrements of the
activation counter of B (by iterating the target_list) before finally
activating B.

This is not optimal, we can share the same activation count for all the
links between A and B.

Add a new pw_node_peer struct to keep track of links between A and B.
Activating a link between A and B activates the single activation of B,
deactivating all links deactivates B again. Waking up B after A finished
now no longer depends on the number of links between A and B.

This is particularly important for remote nodes because before the patch
they would get the activation memory and the eventfd of the peer __for
each link__. With huge amounts of links (like in stress tests) this
would result in too many fds. filtering out the fds for the same peer
was not easily possible because the server would still increment the
counters for each link and sharing the eventfd would require refcounting
it and closing duplicates.

After this patch the remote node receives 1 activation memory and eventfd
for each peer node, independent of the number of links between them. Even
for stereo streams this saves half of the memory and fds.
2023-05-10 16:56:38 +02:00
Wim Taymans
742039ff3f jack: destroy port only after emitting the portregistration
In jack_port_unregister(), don't free the port completely but mark it
as removing. This will then do the portregistration callback before
freeing the port.

Add some more debug.
2023-05-10 16:49:41 +02:00
Wim Taymans
981428a9fc jack: only emit graph order changes for new links 2023-05-10 16:48:57 +02:00
Wim Taymans
844ab48db8 jack: use refcount for freezing callbacks
In case the callbacks are called recursively, use a refcount for
blocking the callback emission.

See #3183
2023-05-10 16:46:42 +02:00