mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-06-29 13:14:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: {libcamera,v4l2}: device: remove params

Browse source 
No params are implemented, so remove them from the emitted `spa_device_info`.
For v4l2, `n_params` was already set to 0 in 938e2b1451
("v4l2: profiles params are not implement yet"), effectively removing them.

No implementation has materialized in the last 5 years, so remove them
altogether, and do the same in the libcamera plugin as well.
This commit is contained in:
Barnabás Pőcze 2026-06-19 15:21:01 +02:00
parent 2a4222a538
commit a5ade5f96e
2 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spa/plugins/libcamera/libcamera-device.cpp
View file

@ -102,7 +102,6 @@ int emit_info(struct impl *impl, bool full)
struct spa_dict dict; struct spa_dict dict;
uint32_t n_items = 0; uint32_t n_items = 0;
struct spa_device_info info; struct spa_device_info info;
struct spa_param_info params[2];
Camera& camera = *impl->camera; Camera& camera = *impl->camera;
info = SPA_DEVICE_INFO_INIT(); info = SPA_DEVICE_INFO_INIT();
@ -153,12 +152,6 @@ int emit_info(struct impl *impl, bool full)
dict = SPA_DICT_INIT(items, n_items); dict = SPA_DICT_INIT(items, n_items);
info.props = &dict; info.props = &dict;
info.change_mask |= SPA_DEVICE_CHANGE_MASK_PARAMS;
params[0] = SPA_PARAM_INFO(SPA_PARAM_EnumProfile, SPA_PARAM_INFO_READ);
params[1] = SPA_PARAM_INFO(SPA_PARAM_Profile, SPA_PARAM_INFO_WRITE);
info.n_params = SPA_N_ELEMENTS(params);
info.params = params;
spa_device_emit_info(&impl->hooks, &info); spa_device_emit_info(&impl->hooks, &info);
if (true) { if (true) {

7
spa/plugins/v4l2/v4l2-device.c
View file

@ -61,7 +61,6 @@ static int emit_info(struct impl *this, bool full)
struct spa_dict_item items[13]; struct spa_dict_item items[13];
uint32_t n_items = 0; uint32_t n_items = 0;
struct spa_device_info info; struct spa_device_info info;
struct spa_param_info params[2];
char path[128], version[16], capabilities[16], device_caps[16], devices_str[16]; char path[128], version[16], capabilities[16], device_caps[16], devices_str[16];
struct spa_strbuf buf; struct spa_strbuf buf;
@ -105,12 +104,6 @@ static int emit_info(struct impl *this, bool full)
#undef ADD_ITEM #undef ADD_ITEM
info.props = &SPA_DICT_INIT(items, n_items); info.props = &SPA_DICT_INIT(items, n_items);
info.change_mask |= SPA_DEVICE_CHANGE_MASK_PARAMS;
params[0] = SPA_PARAM_INFO(SPA_PARAM_EnumProfile, SPA_PARAM_INFO_READ);
params[1] = SPA_PARAM_INFO(SPA_PARAM_Profile, SPA_PARAM_INFO_WRITE);
info.n_params = 0;
info.params = params;
spa_device_emit_info(&this->hooks, &info); spa_device_emit_info(&this->hooks, &info);
if (spa_v4l2_is_capture(&this->dev)) { if (spa_v4l2_is_capture(&this->dev)) {