From a5ade5f96ef705fcfa32b9b2569f16d7e72c3b33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Fri, 19 Jun 2026 15:21:01 +0200 Subject: [PATCH] spa: {libcamera,v4l2}: device: remove params No params are implemented, so remove them from the emitted `spa_device_info`. For v4l2, `n_params` was already set to 0 in 938e2b14516e ("v4l2: profiles params are not implement yet"), effectively removing them. No implementation has materialized in the last 5 years, so remove them altogether, and do the same in the libcamera plugin as well. --- spa/plugins/libcamera/libcamera-device.cpp | 7 ------- spa/plugins/v4l2/v4l2-device.c | 7 ------- 2 files changed, 14 deletions(-) diff --git a/spa/plugins/libcamera/libcamera-device.cpp b/spa/plugins/libcamera/libcamera-device.cpp index c135b78b1..a4691007b 100644 --- a/spa/plugins/libcamera/libcamera-device.cpp +++ b/spa/plugins/libcamera/libcamera-device.cpp @@ -102,7 +102,6 @@ int emit_info(struct impl *impl, bool full) struct spa_dict dict; uint32_t n_items = 0; struct spa_device_info info; - struct spa_param_info params[2]; Camera& camera = *impl->camera; info = SPA_DEVICE_INFO_INIT(); @@ -153,12 +152,6 @@ int emit_info(struct impl *impl, bool full) dict = SPA_DICT_INIT(items, n_items); info.props = &dict; - info.change_mask |= SPA_DEVICE_CHANGE_MASK_PARAMS; - params[0] = SPA_PARAM_INFO(SPA_PARAM_EnumProfile, SPA_PARAM_INFO_READ); - params[1] = SPA_PARAM_INFO(SPA_PARAM_Profile, SPA_PARAM_INFO_WRITE); - info.n_params = SPA_N_ELEMENTS(params); - info.params = params; - spa_device_emit_info(&impl->hooks, &info); if (true) { diff --git a/spa/plugins/v4l2/v4l2-device.c b/spa/plugins/v4l2/v4l2-device.c index f29252d16..54b0b78f0 100644 --- a/spa/plugins/v4l2/v4l2-device.c +++ b/spa/plugins/v4l2/v4l2-device.c @@ -61,7 +61,6 @@ static int emit_info(struct impl *this, bool full) struct spa_dict_item items[13]; uint32_t n_items = 0; struct spa_device_info info; - struct spa_param_info params[2]; char path[128], version[16], capabilities[16], device_caps[16], devices_str[16]; struct spa_strbuf buf; @@ -105,12 +104,6 @@ static int emit_info(struct impl *this, bool full) #undef ADD_ITEM info.props = &SPA_DICT_INIT(items, n_items); - info.change_mask |= SPA_DEVICE_CHANGE_MASK_PARAMS; - params[0] = SPA_PARAM_INFO(SPA_PARAM_EnumProfile, SPA_PARAM_INFO_READ); - params[1] = SPA_PARAM_INFO(SPA_PARAM_Profile, SPA_PARAM_INFO_WRITE); - info.n_params = 0; - info.params = params; - spa_device_emit_info(&this->hooks, &info); if (spa_v4l2_is_capture(&this->dev)) {