copilot-swe-agent[bot]
0bcc5d7546
Address code review feedback: improve comment clarity and remove duplicate
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:52:08 +00:00
copilot-swe-agent[bot]
2c181fcb21
Translate all Chinese comments to English in source files
...
- Translate comments in src/client/client.h
- Translate comments in src/config/parse_config.h
- Translate comments in src/data/static_keymap.h
- Translate comments in src/dispatch/bind_define.h
- Translate comments in src/ext-protocol/*.h
- Translate comments in src/fetch/*.h
- Translate comments in src/layout/*.h
- Translate comments in src/mango.c
All Chinese comments have been accurately translated to English
while preserving the technical meaning and context.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-18 09:50:35 +00:00
copilot-swe-agent[bot]
288710ad9e
Translate Chinese comments to English in mmsg.c and animation files
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:40:42 +00:00
Ricardo Squassina Lee
30d6acea0c
Merge pull request #2 from squassina/copilot/fix-security-issues
...
Fix critical security vulnerabilities in string handling and memory management
2026-02-18 06:10:11 -03:00
copilot-swe-agent[bot]
1350b7787a
Final code polish for consistency and correctness
...
- Use int32_t consistently in all loops
- Add zero-length check before memcpy
- Improve error detection in strtol (comment clarification)
- Ensure null terminator always has space reserved
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:04:20 +00:00
copilot-swe-agent[bot]
3f0c11b068
Translate final Chinese comments in mango.c and parse_config.h
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:03:32 +00:00
copilot-swe-agent[bot]
969c68b66d
Fix remaining memory and buffer issues
...
- Use memcpy with pointer arithmetic for safe string concatenation
- Track and free allocated strings in spawn error path
- Properly account for null terminator in all buffer operations
- Eliminate potential buffer overflows from strncat edge cases
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:03:32 +00:00
copilot-swe-agent[bot]
5d145cc80f
Simplify code based on final review feedback
...
- Use direct character assignment for constant strings
- Remove unnecessary tracking array and cleanup code
- Simplify string concatenation logic
- Fix length calculation to match actual strncat behavior
- Code is cleaner and more maintainable
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:02:22 +00:00
copilot-swe-agent[bot]
ffa83cd0fc
Translate remaining Chinese comments in parse_config.h to English
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:01:48 +00:00
copilot-swe-agent[bot]
21088fe86a
Final refinements for security and performance
...
- Add explicit null termination for consistency
- Optimize string concatenation to avoid redundant strlen calls
- Track actual characters added to maintain O(n) complexity
- Improve code clarity with better comments
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:01:20 +00:00
copilot-swe-agent[bot]
12fe0abca1
Polish security fixes with minor improvements
...
- Remove redundant null termination for short strings
- Use descriptive variable names in cleanup loop
- Cache strlen results to avoid O(n²) complexity in string concatenation
- Add bounds checks before string operations
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 09:00:02 +00:00
copilot-swe-agent[bot]
3336d8d8ee
Address code review feedback: improve array formatting and extract size constant
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:58:37 +00:00
copilot-swe-agent[bot]
e2649dd84f
Final security improvements based on code review
...
- Add LAYOUT_ABBR_SIZE constant to avoid magic numbers
- Track allocated argv entries to properly free on error
- Simplify strncat bounds checking using strlen for accuracy
- Ensure all allocated memory is freed in error paths
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:58:36 +00:00
copilot-swe-agent[bot]
d017fc4837
Address code review feedback on security fixes
...
- Fix buffer size for strncpy to match actual buffer (32 bytes)
- Use strtoul instead of strtol for unsigned color values
- Improve strncat bounds checking with accurate length tracking
- Free wordexp results immediately after use instead of batching
- Add strdup for wordexp strings to avoid use-after-free
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:57:08 +00:00
copilot-swe-agent[bot]
c08c9c4fb8
Add macro documentation and translate remaining Chinese comments
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:56:21 +00:00
copilot-swe-agent[bot]
9d2f852ec2
Fix critical buffer overflow and memory leak vulnerabilities
...
- Replace unsafe strcpy() with strncpy() in fetch/common.h
- Replace unsafe strcpy() with strncpy() in config parsing
- Fix buffer overflow from strcat() by adding bounds checking
- Fix memory leak by adding wordfree() for wordexp results
- Add integer overflow validation for strtol() calls
- Add errno checking for all strtol conversions
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:54:42 +00:00
copilot-swe-agent[bot]
73995e5828
Improve code readability: refactor animation code and translate comments
...
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-18 08:54:36 +00:00
DreamMaoMao
c3dcee2c8e
opt: remove useless code
2026-02-17 08:33:45 +08:00
DreamMaoMao
112fb5c007
opt: optimize code struct
2026-02-16 10:06:16 +08:00
DreamMaoMao
1158fb2e3c
opt: don't skip frame when grab client
2026-02-16 07:46:42 +08:00
DreamMaoMao
7ccbeae8b8
fix: if the progress not the child of main, not assume it is stop
2026-02-15 14:08:53 +08:00
DreamMaoMao
49cb5a9d7e
feat: support frame skip for x11 app resize
2026-02-15 12:50:42 +08:00
DreamMaoMao
0696fe964d
opt: optimize frame skip logic
2026-02-15 10:31:23 +08:00
DreamMaoMao
842b45b584
feat: add skip timer to avoid rermanently block render
2026-02-15 09:02:36 +08:00
DreamMaoMao
02067e3b1e
fix: some client property missing init
2026-02-15 08:07:00 +08:00
DreamMaoMao
fdd54afb7e
fix: some app frame skip fail when disable animaitons
2026-02-15 08:00:44 +08:00
DreamMaoMao
91110efe0e
Merge pull request #645 from jampe/feature-config-isfakefullscreen
...
support isfakefullscreen as windowrule property
2026-02-14 08:46:23 +08:00
DreamMaoMao
89413aacf5
fix: fix center tile size per reset
2026-02-14 08:35:30 +08:00
DreamMaoMao
0fe87e6286
fix: fix multi master focus record error
2026-02-13 20:23:03 +08:00
DreamMaoMao
c05eec7f53
feat: support restore stack from non-tile state
2026-02-13 20:02:23 +08:00
DreamMaoMao
8a924494c6
opt: the tagset is current tagset when open window in ov mode
2026-02-13 18:16:06 +08:00
DreamMaoMao
711498490b
opt: not back to ov tag when view prev tag
2026-02-13 18:11:18 +08:00
DreamMaoMao
f251615524
opt: flush the blur background cache when unmap a background layer
2026-02-13 11:07:11 +08:00
DreamMaoMao
313adefd10
opt: better x11 coordinate adjust
2026-02-12 18:55:03 +08:00
DreamMaoMao
17acdae69c
opt: make x11 floating window coordinate auto ajust the monitor change
2026-02-12 18:12:01 +08:00
DreamMaoMao
bc52b95c1e
opt: make x11 unmanaged window coordinate auto ajust the monitor change
2026-02-12 18:10:02 +08:00
DreamMaoMao
53ee82a726
feat: make force_tiled_state as a option
2026-02-12 11:19:39 +08:00
DreamMaoMao
8484093e32
fix: crash when pointerfocus to a null scene client
2026-02-11 20:44:44 +08:00
DreamMaoMao
b5a157038c
opt: tell the synckeymap timer not need to call anymore
2026-02-11 08:31:22 +08:00
DreamMaoMao
783cb86c56
feat: support match monitor make model serial
2026-02-10 10:31:31 +08:00
DreamMaoMao
b05bc1ce65
opt: add btn_left and btn_right bind check in config check
2026-02-09 11:50:54 +08:00
DreamMaoMao
6b79a432a4
opt: allow none mode in some mouse button
2026-02-09 11:18:14 +08:00
Daniel Jampen
454145f6e0
support isfakefullscreen as windowrule property
2026-02-08 17:56:26 +01:00
DreamMaoMao
e8bf6380fb
opt: turn keymap sync into XWAYLAND macro
2026-02-08 12:44:56 +08:00
DreamMaoMao
4820b7a8ab
feat: allow single mod keybind
2026-02-08 12:15:44 +08:00
DreamMaoMao
faf2e1e9da
opt: sync keymap to xwayland after xwayland ready
2026-02-08 12:13:04 +08:00
DreamMaoMao
acf8363714
Merge pull request #642 from iynaix/source-optional
...
feat: add a source-optional keyword
2026-02-08 11:27:22 +08:00
DreamMaoMao
241afb4b97
fix: warpcursor not apply in some case
2026-02-08 11:18:38 +08:00
Lin Xianyi
5de87db8ca
feat: add a source-optional keyword
2026-02-08 11:15:16 +08:00
DreamMaoMao
9b92f139c0
fix: correct dmabuf version
2026-02-07 21:46:18 +08:00