mirror of
https://github.com/labwc/labwc.git
synced 2026-02-05 04:06:33 -05:00
bad788ccdd
The previous revert fixed the problem of stuck modifier keys with
keybinds in Blender, but made Firefox show its menu bar with Alt-*
keybinds. This is fundamentally inevitable due to the limitation of
wayland protocol, but at least for the default Alt-Tab keybind for
window switcher, we can mitigate this problem by clearing the keyboard
focus when the window switcher is activated. This is what KWin does, and
we decided to follow that.
So in this commit, keyboard and pointer focus are temporarily cleared
while Move/Resize, window switcher and menu interactions and restored
after them. We slightly deviate from KWin as KWin doesn't clear the
keyboard focus while Move/Resize, but it solves our existing problem
that Firefox shows its menu bar after dragging it with default Alt-Drag
mousebind, and this is what Mutter does.
We considered other solutions, but they don't work well:
1. Send wl_keyboard.{leave,enter} every time keybinds/mousebinds are
triggered. This solves the Firefox's menu bar problem, but that
sounds like a workaround and sending unnecessary events every time is
not desirable.
2. Send release events for both modifiers and keys even when they are
bound to keybinds. This is what Mutter is doing, but it looks like an
implementation issue and violates wayland protocol.
|
||
|---|---|---|
| .. | ||
| common | ||
| config | ||
| img | ||
| input | ||
| menu | ||
| protocols | ||
| action.h | ||
| buffer.h | ||
| debug.h | ||
| decorations.h | ||
| desktop-entry.h | ||
| dnd.h | ||
| edges.h | ||
| foreign-toplevel-internal.h | ||
| foreign-toplevel.h | ||
| idle.h | ||
| labwc.h | ||
| layers.h | ||
| magnifier.h | ||
| meson.build | ||
| node.h | ||
| osd.h | ||
| output-state.h | ||
| output-virtual.h | ||
| overlay.h | ||
| placement.h | ||
| regions.h | ||
| resistance.h | ||
| resize-indicator.h | ||
| resize-outlines.h | ||
| session-lock.h | ||
| snap-constraints.h | ||
| snap.h | ||
| ssd-internal.h | ||
| ssd.h | ||
| theme.h | ||
| view-impl-common.h | ||
| view.h | ||
| window-rules.h | ||
| workspaces.h | ||
| xwayland.h | ||