mirror of
https://github.com/labwc/labwc.git
synced 2025-10-31 22:25:34 -04:00
ef766d16f0
I like the new common/edge.h. I don't like how inconsistently we use it. Current situation: - enum wlr_edges and wlr_direction are designed to be used as bitset, and are defined compatibly - enum lab_edge is *also* designed to be used as bitset, but incompatible with the others (LEFT/RIGHT come before UP/DOWN) - we use an inconsistent mix of all three *AND* uint32_t (usually with the WLR_EDGE constants rather than the LAB_EDGE constants), and convert between them on an ad-hoc basis, sometimes implicitly Let's clean this up: - reorder enum lab_edge to be compatible with the two wlr enums (check this by static_assert) - use TOP/BOTTOM naming rather than UP/DOWN (matches wlr_edges) - add constants for the remaining possible combinations of the 4 edges - use lab_edge for all internal edge/direction fields, consistently - add lab_edge_is_cardinal() as a sanity check before casting to enum wlr_direction, and then eliminate all of direction.c/h Instead of "enum wlr_edges direction", we now have "enum lab_edge direction" which is not that much better. At least we are now clear that we're overloading one enum with two meanings.
114 lines
3.4 KiB
C
114 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/* view-impl-common.c: common code for shell view->impl functions */
|
|
#include "view-impl-common.h"
|
|
#include <strings.h>
|
|
#include "foreign-toplevel/foreign.h"
|
|
#include "labwc.h"
|
|
#include "view.h"
|
|
#include "window-rules.h"
|
|
|
|
void
|
|
view_impl_map(struct view *view)
|
|
{
|
|
desktop_focus_view(view, /*raise*/ true);
|
|
view_update_title(view);
|
|
view_update_app_id(view);
|
|
if (!view->been_mapped) {
|
|
window_rules_apply(view, LAB_WINDOW_RULE_EVENT_ON_FIRST_MAP);
|
|
}
|
|
|
|
/*
|
|
* It's tempting to just never create the foreign-toplevel handle in the
|
|
* map handlers, but the app_id/title might not have been set at that
|
|
* point, so it's safer to process the property here
|
|
*/
|
|
enum property ret = window_rules_get_property(view, "skipTaskbar");
|
|
if (ret == LAB_PROP_TRUE) {
|
|
if (view->foreign_toplevel) {
|
|
foreign_toplevel_destroy(view->foreign_toplevel);
|
|
view->foreign_toplevel = NULL;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Some clients (e.g. Steam's Big Picture Mode window) request
|
|
* fullscreen before mapping.
|
|
*/
|
|
desktop_update_top_layer_visibility(view->server);
|
|
|
|
wlr_log(WLR_DEBUG, "[map] identifier=%s, title=%s",
|
|
view_get_string_prop(view, "app_id"),
|
|
view_get_string_prop(view, "title"));
|
|
}
|
|
|
|
void
|
|
view_impl_unmap(struct view *view)
|
|
{
|
|
struct server *server = view->server;
|
|
/*
|
|
* When exiting an xwayland application with multiple views
|
|
* mapped, a race condition can occur: after the topmost view
|
|
* is unmapped, the next view under it is offered focus, but is
|
|
* also unmapped before accepting focus (so server->active_view
|
|
* remains NULL). To avoid being left with no active view at
|
|
* all, check for that case also.
|
|
*/
|
|
if (view == server->active_view || !server->active_view) {
|
|
desktop_focus_topmost_view(server);
|
|
}
|
|
}
|
|
|
|
static bool
|
|
resizing_edge(struct view *view, enum lab_edge edge)
|
|
{
|
|
struct server *server = view->server;
|
|
return server->input_mode == LAB_INPUT_STATE_RESIZE
|
|
&& server->grabbed_view == view
|
|
&& (server->resize_edges & edge);
|
|
}
|
|
|
|
void
|
|
view_impl_apply_geometry(struct view *view, int w, int h)
|
|
{
|
|
struct wlr_box *current = &view->current;
|
|
struct wlr_box *pending = &view->pending;
|
|
struct wlr_box old = *current;
|
|
|
|
/*
|
|
* Anchor right edge if resizing via left edge.
|
|
*
|
|
* Note that answering the question "are we resizing?" is a bit
|
|
* tricky. The most obvious method is to look at the server
|
|
* flags; but that method will not account for any late commits
|
|
* that occur after the mouse button is released, as the client
|
|
* catches up with pending configure requests. So as a fallback,
|
|
* we resort to a geometry-based heuristic -- also not 100%
|
|
* reliable on its own. The combination of the two methods
|
|
* should catch 99% of resize cases that we care about.
|
|
*/
|
|
bool resizing_left_edge = resizing_edge(view, LAB_EDGE_LEFT);
|
|
if (resizing_left_edge || (current->x != pending->x
|
|
&& current->x + current->width ==
|
|
pending->x + pending->width)) {
|
|
current->x = pending->x + pending->width - w;
|
|
} else {
|
|
current->x = pending->x;
|
|
}
|
|
|
|
/* Anchor bottom edge if resizing via top edge */
|
|
bool resizing_top_edge = resizing_edge(view, LAB_EDGE_TOP);
|
|
if (resizing_top_edge || (current->y != pending->y
|
|
&& current->y + current->height ==
|
|
pending->y + pending->height)) {
|
|
current->y = pending->y + pending->height - h;
|
|
} else {
|
|
current->y = pending->y;
|
|
}
|
|
|
|
current->width = w;
|
|
current->height = h;
|
|
|
|
if (!wlr_box_equal(current, &old)) {
|
|
view_moved(view);
|
|
}
|
|
}
|