mirror of
https://github.com/labwc/labwc.git
synced 2026-03-27 07:58:31 -04:00
tree-wide: use die_if_null() for wlr_scene alloc failures
Some checks failed
labwc.github.io / notify (push) Has been cancelled
Some checks failed
labwc.github.io / notify (push) Has been cancelled
wlr_scene_*_create() functions all allocate memory via calloc() and return NULL if the allocation fails. Previously, the failures were handled in any of 3 different ways: - sending a wayland protocol error - exiting labwc with an error - segfault (no NULL check at all) Since labwc does not attempt to survive heap exhaustion in other allocation paths (such as `znew`), it seems more consistent to use the same die_if_null() check used in those paths to exit with an error. For the three most common create() functions (tree, rect, buffer), add small lab_wlr_ wrappers to common/scene-helpers.
This commit is contained in:
parent
c4effef0ec
commit
16c5373be5
27 changed files with 155 additions and 141 deletions
|
|
@ -4,6 +4,7 @@
|
|||
#include <wlr/types/wlr_data_device.h>
|
||||
#include <wlr/types/wlr_scene.h>
|
||||
#include <wlr/util/log.h>
|
||||
#include "common/scene-helpers.h"
|
||||
#include "config/rcxml.h"
|
||||
#include "input/cursor.h"
|
||||
#include "labwc.h" /* for struct seat */
|
||||
|
|
@ -83,7 +84,7 @@ handle_drag_destroy(struct wl_listener *listener, void *data)
|
|||
void
|
||||
dnd_init(struct seat *seat)
|
||||
{
|
||||
seat->drag.icons = wlr_scene_tree_create(&seat->server->scene->tree);
|
||||
seat->drag.icons = lab_wlr_scene_tree_create(&seat->server->scene->tree);
|
||||
wlr_scene_node_set_enabled(&seat->drag.icons->node, false);
|
||||
|
||||
seat->drag.events.request.notify = handle_drag_request;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue