mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2026-03-17 05:33:47 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

xwayland: fix missing title and icon with override-redirect toggle

Browse source 
When an X11 client clears override-redirect on a window (i.e. it
becomes "managed") without an unmap/map cycle, wlroots doesn't
re-emit the set_title/class/icon events. We need to synthesize
them to re-read the values from the surface.

From what I can tell, only older/misbehaving X11 clients would
actually do this (toggle override-redirect without unmap/map), so
this is perhaps a bit pedantic, but an easy fix anyway.
This commit is contained in:
John Lindgren 2026-03-14 02:34:23 -04:00 • committed by Johan Malm
parent 5a9ae66332
commit c4effef0ec
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/xwayland.c
View file

@ -1091,6 +1091,16 @@ xwayland_view_create(struct server *server,
if (xsurface->surface) {
handle_associate(&xwayland_view->associate, NULL);
/*
* If a surface is already associated, then we've
* missed the various initial set_* events as well.
*
* TODO: update_icon() -> handle_set_icon() after
* https://github.com/labwc/labwc/pull/2760
*/
handle_set_title(&view->set_title, NULL);
handle_set_class(&xwayland_view->set_class, NULL);
update_icon(xwayland_view);
}
if (mapped) {
handle_map(&xwayland_view->base.mappable.map, NULL);