mirror of
https://github.com/labwc/labwc.git
synced 2026-04-07 08:21:20 -04:00
tree-wide: use die_if_null() for wlr_scene alloc failures
Some checks failed
labwc.github.io / notify (push) Has been cancelled
Some checks failed
labwc.github.io / notify (push) Has been cancelled
wlr_scene_*_create() functions all allocate memory via calloc() and return NULL if the allocation fails. Previously, the failures were handled in any of 3 different ways: - sending a wayland protocol error - exiting labwc with an error - segfault (no NULL check at all) Since labwc does not attempt to survive heap exhaustion in other allocation paths (such as `znew`), it seems more consistent to use the same die_if_null() check used in those paths to exit with an error. For the three most common create() functions (tree, rect, buffer), add small lab_wlr_ wrappers to common/scene-helpers.
This commit is contained in:
parent
c4effef0ec
commit
16c5373be5
27 changed files with 155 additions and 141 deletions
|
|
@ -231,7 +231,7 @@ preview_selected_view(struct view *view)
|
|||
cycle->preview_node = &view->scene_tree->node;
|
||||
|
||||
/* Create a dummy node at the original place of the previewed window */
|
||||
struct wlr_scene_rect *dummy_rect = wlr_scene_rect_create(
|
||||
struct wlr_scene_rect *dummy_rect = lab_wlr_scene_rect_create(
|
||||
cycle->preview_node->parent, 0, 0, (float [4]) {0});
|
||||
wlr_scene_node_place_below(&dummy_rect->node, cycle->preview_node);
|
||||
wlr_scene_node_set_enabled(&dummy_rect->node, false);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue