Commit graph

2887 commits

Author SHA1 Message Date
Daniel Eklöf
b507d3a55e
osc: change info logging to debug logging when changing the cursor color 2020-10-20 21:03:51 +02:00
Daniel Eklöf
0d319f8793
input: handle XKB errors
* Don’t de-reference the xkb context/keymap/state if we failed to
  instantiate them.
* Don’t try to send a translated utf8 key sequence if the translation
  failed.
* Handle xkb_compose_state_get_utf8() and xkb_state_key_get_utf8()
  returning more than 64 bytes.

This _may_ fix #171.
2020-10-20 21:01:33 +02:00
Daniel Eklöf
4c3d2cfc7d
input: don’t allow diagonal resize when tiled 2020-10-20 21:00:19 +02:00
Daniel Eklöf
f928c1fa68
wayland: properly restore window size when being un-tiled
Bind to xdg-shell version 2 if available, as this enables us to
track our window’s ‘tiled’ state in the ‘configure’ events.

This in turn allows us to stash the ‘old’ window size when being
tiled, to be used again when restoring the window size when un-tiled.
2020-10-20 20:58:03 +02:00
Daniel Eklöf
f70d36ed5d
Merge branch 'dont-require-a-compose-file' into master
Closes #170
2020-10-20 20:55:47 +02:00
Daniel Eklöf
0573c685c7
input: don’t crash if xkbcommon cannot find a compose file
Handle xkb_compose_table_new_from_locale() returning NULL. When this
happens, log a warning that “dead keys” will be disabled, and make
sure to never de-reference the compose table pointer.

Closes #170
2020-10-19 18:30:19 +02:00
Daniel Eklöf
e6737034e5
term: reset: enable/disable cursor blink depending on user configuration 2020-10-13 19:28:56 +02:00
Daniel Eklöf
2cac832ef3
term: reset: kill blink timer 2020-10-13 19:28:42 +02:00
Daniel Eklöf
1f650a7fdf
term: remove unneeded blink.active field
We now use the timer FD instead; if it is -1, blinking is not active.
2020-10-13 19:28:05 +02:00
Daniel Eklöf
ac55e4067a
term: instantiate cursor blink timer on-demand 2020-10-13 19:23:04 +02:00
Daniel Eklöf
c63199429e
term: create/destroy blink timer on-demand
Blinking text is uncommon. It doesn’t make that much sense to keep a
timer opened (but unarmed) at all times.

This patch makes it so the timer is instantiated on-demand, and
destroyed again when it no longer is needed.
2020-10-13 18:40:20 +02:00
Daniel Eklöf
7a218cba08
term: subpixel changed: fix build with LOG_ENABLE_DBG=1 2020-10-13 18:39:36 +02:00
Daniel Eklöf
033ff180af
selection: re-factor: break out code shared between clipboard/primary send
The send functions are called by the compositor when another
application wants to paste data *from* foot.
2020-10-13 18:38:49 +02:00
Daniel Eklöf
8b06a55cb0
Merge branch 'releases/1.5' into master 2020-10-13 08:06:56 +02:00
Daniel Eklöf
f1e422b25a
meson/pkgbuild: bump version to 1.5.2 2020-10-13 08:04:37 +02:00
Daniel Eklöf
fdb7e40355
input: regression: don’t pass on mouse click to application if we consumed it
When we ‘consume’ a mouse button event (i.e. when we have a shortcut
mapped to it), the event should *not* be passed on to the client
application.

In 5f64c5c335, button handling was
refactored and unfortunately introduced a regression where we once
again started passing consumed button presses to the client
application.

Fixes #168
2020-10-13 08:02:09 +02:00
Daniel Eklöf
d75e50230e
Merge branch 'scroll-up-down-while-selecting' into master
Closes #149
2020-10-12 20:20:26 +02:00
Daniel Eklöf
27cb17e71e
Merge branch 'releases/1.5' into master 2020-10-11 19:36:00 +02:00
Daniel Eklöf
2f20550893
meson/pkgbuild: bump version to 1.5.1 2020-10-11 19:31:25 +02:00
Daniel Eklöf
77a87b30ff
changelog: prepare for 1.5.1 2020-10-11 19:31:01 +02:00
Daniel Eklöf
a32464e296
changelog: remove duplicate entry 2020-10-11 19:27:37 +02:00
Daniel Eklöf
16a525f8e2
readme/doc: add shift+insert to list of default key bindings 2020-10-11 19:27:15 +02:00
Daniel Eklöf
70a6f88823
changelog: update ‘contributors’ list 2020-10-11 19:27:12 +02:00
Sergey Nazaryev
e842f49367
selection: use appropriate check for PRIMARY paste
Assume it could be a copy-paste typo. We should check PRIMARY, not
CLIPBOARD. Without this fix, we can't use PRIMARY until we copy anything
to CLIPBOARD.
2020-10-11 19:27:07 +02:00
Daniel Eklöf
282af44784
config: bind shift+insert to primary-paste by default 2020-10-11 19:26:57 +02:00
Daniel Eklöf
4bf61fe2f1
changelog: add contributor 2020-10-11 19:26:36 +02:00
Craig Barnes
f1752c7642
config: fix "-Wformat-nonliteral" warnings 2020-10-11 19:26:32 +02:00
Daniel Eklöf
5540e3a0e2
readme: minor rewrite of server/daemon section 2020-10-11 19:26:27 +02:00
Daniel Eklöf
5477ee8894
csi: only respond to Primary DA when Ps == 0 2020-10-11 19:26:25 +02:00
Daniel Eklöf
5daaaa03c2
readme: clearer descriptions of secondary and tertiary DA responses 2020-10-11 19:26:22 +02:00
Daniel Eklöf
0fa4a18938
term: remove unused bit in xtsave struct 2020-10-11 19:26:19 +02:00
Daniel Eklöf
98c316556f
changelog: we’ve fixed several sixel+reflow related bugs 2020-10-11 19:26:10 +02:00
Daniel Eklöf
d0c5cf6e9f
sixel: reflow: drop sixels that crosses the scrollback history’s end
This fixes various crashes that occurred after a reflow due to the
sixel image list invariants no longer being true.
2020-10-11 19:26:09 +02:00
Daniel Eklöf
d54adc5263
sixel: unhook: do overwrite *after* linefeeding
This ensures the overwrite is done when the scrollback history is in
the same state as when we then insert the new image.
2020-10-11 19:26:07 +02:00
Daniel Eklöf
0e4b0fefc1
sixel: overwrite: use pixman to calculate new the sixel boundaries
When punching a hole in a sixel (and thus splitting it up into up to
four new sixels), use pixman to calculate the new sixel coordinates
and sizes.
2020-10-11 19:26:05 +02:00
Daniel Eklöf
329a290f82
sixel: ovewrite-by-rectangle: in debug builds, cross-reference against pixman
Use pixman to calculate the intersection of the rectangle being
overwritten, and the sixel(s). Verify our code matches.
2020-10-11 19:26:03 +02:00
Daniel Eklöf
09e8a5b11d
sixel: verify scrollback consistency: new verify function
Verifies sixels have been scrolled out correctly
2020-10-11 19:26:01 +02:00
Daniel Eklöf
cc54c1bea7
sixel: add comments to verify_*() functions 2020-10-11 19:26:00 +02:00
Daniel Eklöf
0a802c2693
sixel: verify-*: don’t return anything; rely on asserts only 2020-10-11 19:25:58 +02:00
Daniel Eklöf
eec0971739
sixel: scroll up/down: early return when list is empty
Branch tagged as ‘likely’ for performance reason
2020-10-11 19:25:56 +02:00
Daniel Eklöf
3540031dc6
sixel: cell-size-changed: don’t verify sixels here
The state after this function is an intermediate state and isn’t
necessarily valid.

This sixels needs to be ‘reflowed’ to ensure a valid state. This is
something that should be done by the caller after the text grid has
been reflowed and the sixel coordinates have been re-mapped to the new
grid.

TODO: can/should we update the sixel cols/rows in sixel_reflow()
instead?
2020-10-11 19:25:55 +02:00
Daniel Eklöf
f834ae8add
sixel: unhook: look total number of sixels
This helps debug sixel overwrites, as it makes it more visible when
there are sixels that _should_ have been removed.
2020-10-11 19:25:53 +02:00
Daniel Eklöf
47c884da53
sixel: scroll-up: don’t break out early of loop
This function loops the list of sixels, and discards those that would
be scrolled out if the grid offset is moved forward by the specified
number of rows.

The criteria is when the rebased row value is less than the number of
rows to scroll.

A rebased row number is a zero-based number starting at the beginning
of the scrollback. Thus, when scrolling 5 rows, rows with a rebased
row number between 0-4 will be scrolled out.

For performance reasons, we used to break out of the loop as soon as a
row number *larger* than the scroll count.

This however does not work. The sixels are sorted by their *end*
row. While this works in most cases (think images outputted in the
shell in the normal screen), it doesn’t always.

In the alt screen, where applications can print images just about
anywhere, it is possible to have *any* start row number anywhere in
the sixel list. Just as long as their *end* row numbers are sorted.

For example, a huuuge sixel that covers the entire scrollback. This
sixel will naturally be first in the list (and thus sixel_scroll_up()
will visit it *last*, since it iterates the list in reverse), but
should still be destroyed when scrolling.
2020-10-11 19:25:51 +02:00
Daniel Eklöf
5a2cc9c9ae
sixel: verify-list-order: add an ‘index’ variable
This will make it easier when debugging assertions in this function.
2020-10-11 19:25:50 +02:00
Daniel Eklöf
96a20c9df7
sixel: overwrite-by-rectangle: assert sixels don’t cross scrollback wrap-around 2020-10-11 19:25:48 +02:00
Daniel Eklöf
6a8130c122
sixel: scroll: call sixel_erase() instead of sixel_destroy()
This ensures the screen is updated correctly. Without this, the sixel
image would remain on screen until force-refreshed by some other means.
2020-10-11 19:25:46 +02:00
Daniel Eklöf
74703822fb
sixel: TOOD -> TODO (fixes codespell build error) 2020-10-11 19:25:44 +02:00
Daniel Eklöf
29d0068462
sixel: verify-no-overlap: free pixman regions 2020-10-11 19:25:43 +02:00
Daniel Eklöf
e8f703eb65
sixel: verify-no-overlap: initialize ‘intersection’ pixman region 2020-10-11 19:25:41 +02:00
Daniel Eklöf
e19ee5f4d1
render: resize: call sixel_reflow() after reflowing grids 2020-10-11 19:25:39 +02:00