mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-05 04:06:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

shm: automatic buffer purging is now delayed one cycle

Browse source 
This ensures we don't purge a buffer that a user is holding a
reference to.
This commit is contained in:
Daniel Eklöf 2019-11-02 01:27:05 +01:00
parent b27cd9cedf
commit c6c75298f3
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

25
shm.c
View file

@ -53,10 +53,28 @@ shm_get_buffer(struct wl_shm *shm, int width, int height, unsigned long cookie)
if (!it->item.busy) {
LOG_DBG("cookie=%lx: re-using buffer from cache", cookie);
it->item.busy = true;
it->item.purge = false;
return &it->item;
}
}
/* Purge buffers marked for purging */
tll_foreach(buffers, it) {
if (it->item.cookie != cookie)
continue;
if (!it->item.purge)
continue;
assert(!it->item.busy);
LOG_DBG("cookie=%lx: purging buffer %p (width=%d, height=%d)",
cookie, &it->item, it->item.width, it->item.height);
buffer_destroy(&it->item);
tll_remove(buffers, it);
}
/* Purge old buffers associated with this cookie */
tll_foreach(buffers, it) {
if (it->item.cookie != cookie)
@ -68,11 +86,8 @@ shm_get_buffer(struct wl_shm *shm, int width, int height, unsigned long cookie)
if (it->item.width == width && it->item.height == height)
continue;
LOG_DBG("cookie=%lx: purging buffer (width=%d, height=%d)",
cookie, it->item.width, it->item.height);
buffer_destroy(&it->item);
tll_remove(buffers, it);
LOG_DBG("cookie=%lx: marking buffer %p for purging", cookie, &it->item);
it->item.purge = true;
}
/*

2
shm.h
View file

@ -13,6 +13,8 @@ struct buffer {
int height;
int stride;
bool purge;
bool busy;
size_t size;
void *mmapped;