From c6c75298f339f313abb282f27dd3ca02fd7ea26a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Sat, 2 Nov 2019 01:27:05 +0100
Subject: [PATCH] shm: automatic buffer purging is now delayed one cycle

This ensures we don't purge a buffer that a user is holding a
reference to.
---
 shm.c | 25 ++++++++++++++++++++-----
 shm.h |  2 ++
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/shm.c b/shm.c
index f58ca3e4..9b1af9a4 100644
--- a/shm.c
+++ b/shm.c
@@ -53,10 +53,28 @@ shm_get_buffer(struct wl_shm *shm, int width, int height, unsigned long cookie)
         if (!it->item.busy) {
             LOG_DBG("cookie=%lx: re-using buffer from cache", cookie);
             it->item.busy = true;
+            it->item.purge = false;
             return &it->item;
         }
     }
 
+    /* Purge buffers marked for purging */
+    tll_foreach(buffers, it) {
+        if (it->item.cookie != cookie)
+            continue;
+
+        if (!it->item.purge)
+            continue;
+
+        assert(!it->item.busy);
+
+        LOG_DBG("cookie=%lx: purging buffer %p (width=%d, height=%d)",
+                cookie, &it->item, it->item.width, it->item.height);
+
+        buffer_destroy(&it->item);
+        tll_remove(buffers, it);
+    }
+
     /* Purge old buffers associated with this cookie */
     tll_foreach(buffers, it) {
         if (it->item.cookie != cookie)
@@ -68,11 +86,8 @@ shm_get_buffer(struct wl_shm *shm, int width, int height, unsigned long cookie)
         if (it->item.width == width && it->item.height == height)
             continue;
 
-        LOG_DBG("cookie=%lx: purging buffer (width=%d, height=%d)",
-                cookie, it->item.width, it->item.height);
-
-        buffer_destroy(&it->item);
-        tll_remove(buffers, it);
+        LOG_DBG("cookie=%lx: marking buffer %p for purging", cookie, &it->item);
+        it->item.purge = true;
     }
 
     /*
diff --git a/shm.h b/shm.h
index cec0ef81..18da7a1f 100644
--- a/shm.h
+++ b/shm.h
@@ -13,6 +13,8 @@ struct buffer {
     int height;
     int stride;
 
+    bool purge;
+
     bool busy;
     size_t size;
     void *mmapped;