mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-03 09:01:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pcm: remove alloca() from snd_pcm_query_chmaps_from_hw()

Browse source 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-14 23:07:31 +09:00 • committed by Takashi Iwai
parent 757c45b2ae
commit 6fdaad70af
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/pcm/pcm_hw.c
View file

@ -1094,7 +1094,7 @@ snd_pcm_query_chmaps_from_hw(int card, int dev, int subdev,
snd_pcm_stream_t stream) snd_pcm_stream_t stream)
{ {
snd_ctl_t *ctl; snd_ctl_t *ctl;
snd_ctl_elem_id_t *id; snd_ctl_elem_id_t id = {0};
unsigned int tlv[2048], *start; unsigned int tlv[2048], *start;
snd_pcm_chmap_query_t **map; snd_pcm_chmap_query_t **map;
int i, ret, nums; int i, ret, nums;
@ -1105,9 +1105,8 @@ snd_pcm_query_chmaps_from_hw(int card, int dev, int subdev,
return NULL; return NULL;
} }
snd_ctl_elem_id_alloca(&id); __fill_chmap_ctl_id(&id, dev, subdev, stream);
__fill_chmap_ctl_id(id, dev, subdev, stream); ret = snd_ctl_elem_tlv_read(ctl, &id, tlv, sizeof(tlv));
ret = snd_ctl_elem_tlv_read(ctl, id, tlv, sizeof(tlv));
snd_ctl_close(ctl); snd_ctl_close(ctl);
if (ret < 0) { if (ret < 0) {
SYSMSG("Cannot read Channel Map TLV\n"); SYSMSG("Cannot read Channel Map TLV\n");