mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-10-29 05:40:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pcm: remove alloca() from snd_pcm_hw_change_timer()

Browse source 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-14 23:07:30 +09:00 • committed by Takashi Iwai
parent 44d803df90
commit 757c45b2ae
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/pcm/pcm_hw.c
View file

@ -351,12 +351,11 @@ static void snd_pcm_hw_close_timer(snd_pcm_hw_t *hw)
static int snd_pcm_hw_change_timer(snd_pcm_t *pcm, int enable)
{
snd_pcm_hw_t *hw = pcm->private_data;
snd_timer_params_t *params;
snd_timer_params_t params = {0};
unsigned int suspend, resume;
int err;
if (enable) {
snd_timer_params_alloca(&params);
err = snd_timer_hw_open(&hw->period_timer,
"hw-pcm-period-event",
SND_TIMER_CLASS_PCM, SND_TIMER_SCLASS_NONE,
@ -406,11 +405,11 @@ static int snd_pcm_hw_change_timer(snd_pcm_t *pcm, int enable)
resume = 1<<SND_TIMER_EVENT_MCONTINUE;
}
}
snd_timer_params_set_auto_start(params, 1);
snd_timer_params_set_ticks(params, 1);
snd_timer_params_set_filter(params, (1<<SND_TIMER_EVENT_TICK) |
snd_timer_params_set_auto_start(&params, 1);
snd_timer_params_set_ticks(&params, 1);
snd_timer_params_set_filter(&params, (1<<SND_TIMER_EVENT_TICK) |
suspend | resume);
err = snd_timer_params(hw->period_timer, params);
err = snd_timer_params(hw->period_timer, &params);
if (err < 0) {
snd_pcm_hw_close_timer(hw);
return err;