mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2026-02-08 10:06:28 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

wl-drm: use resource interface

Browse source 
Instead of hardcoding builtin resource types in
wlr_buffer_from_resource(), use the modular resource interface.
This commit is contained in:
Simon Ser 2022-11-11 15:54:54 +01:00 • committed by Simon Zeni
parent 772066a174
commit f84f7c7710
2 changed files with 25 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

34
types/buffer/resource.c
View file

@ -2,7 +2,6 @@
#include <string.h>
#include <wayland-server.h>
#include <wlr/interfaces/wlr_buffer.h>
#include <wlr/types/wlr_drm.h>
#include <wlr/util/log.h>
#include "types/wlr_buffer.h"
@ -47,27 +46,18 @@ static const struct wlr_buffer_resource_interface *get_buffer_resource_iface(
struct wlr_buffer *wlr_buffer_from_resource(struct wl_resource *resource) {
assert(resource && wlr_resource_is_buffer(resource));
struct wlr_buffer *buffer;
if (wlr_drm_buffer_is_resource(resource)) {
struct wlr_drm_buffer *drm_buffer =
wlr_drm_buffer_from_resource(resource);
buffer = wlr_buffer_lock(&drm_buffer->base);
} else {
const struct wlr_buffer_resource_interface *iface =
get_buffer_resource_iface(resource);
if (!iface) {
wlr_log(WLR_ERROR, "Unknown buffer type");
return NULL;
}
struct wlr_buffer *custom_buffer = iface->from_resource(resource);
if (!custom_buffer) {
wlr_log(WLR_ERROR, "Failed to create %s buffer", iface->name);
return NULL;
}
buffer = wlr_buffer_lock(custom_buffer);
const struct wlr_buffer_resource_interface *iface =
get_buffer_resource_iface(resource);
if (!iface) {
wlr_log(WLR_ERROR, "Unknown buffer type");
return NULL;
}
return buffer;
struct wlr_buffer *buffer = iface->from_resource(resource);
if (!buffer) {
wlr_log(WLR_ERROR, "Failed to create %s buffer", iface->name);
return NULL;
}
return wlr_buffer_lock(buffer);
}