From f55eacac98c2a78466b578c394beca580d41d7ac Mon Sep 17 00:00:00 2001 From: Kenny Levinsen Date: Thu, 26 Sep 2024 00:40:13 +0200 Subject: [PATCH] backend/drm: Do not log on test commit failure A test commit failure is a normal condition, and can easily end up happening once per frame, such as when direct scan-out is attempted. Only log when non-test commits fail. --- backend/drm/atomic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/backend/drm/atomic.c b/backend/drm/atomic.c index 16b08f7a1..b7717355a 100644 --- a/backend/drm/atomic.c +++ b/backend/drm/atomic.c @@ -71,16 +71,14 @@ static bool atomic_commit(struct atomic *atom, struct wlr_drm_backend *drm, int ret = drmModeAtomicCommit(drm->fd, atom->req, flags, page_flip); if (ret != 0) { - enum wlr_log_importance log_level = WLR_ERROR; if (flags & DRM_MODE_ATOMIC_TEST_ONLY) { - log_level = WLR_DEBUG; + return false; } - if (state->connectors_len == 1) { struct wlr_drm_connector *conn = state->connectors[0].connector; - wlr_drm_conn_log_errno(conn, log_level, "Atomic commit failed"); + wlr_drm_conn_log_errno(conn, WLR_ERROR, "Atomic commit failed"); } else { - wlr_log_errno(log_level, "Atomic commit failed"); + wlr_log_errno(WLR_ERROR, "Atomic commit failed"); } char *flags_str = atomic_commit_flags_str(flags); wlr_log(WLR_DEBUG, "(Atomic commit flags: %s)",