diff --git a/include/render/gles2.h b/include/render/gles2.h index 6b852dcb7..797624c1e 100644 --- a/include/render/gles2.h +++ b/include/render/gles2.h @@ -41,7 +41,6 @@ struct wlr_gles2_renderer { struct wlr_renderer wlr_renderer; struct wlr_egl *egl; - int drm_fd; struct wlr_drm_format_set shm_texture_formats; diff --git a/include/render/vulkan.h b/include/render/vulkan.h index abeb11cc5..a8d121991 100644 --- a/include/render/vulkan.h +++ b/include/render/vulkan.h @@ -38,8 +38,6 @@ struct wlr_vk_device { VkPhysicalDevice phdev; VkDevice dev; - int drm_fd; - bool sync_file_import_export; bool implicit_sync_interop; bool sampler_ycbcr_conversion; diff --git a/include/wlr/render/interface.h b/include/wlr/render/interface.h index 89f6de970..d46caa80f 100644 --- a/include/wlr/render/interface.h +++ b/include/wlr/render/interface.h @@ -25,7 +25,6 @@ struct wlr_renderer_impl { const struct wlr_drm_format_set *(*get_render_formats)( struct wlr_renderer *renderer); void (*destroy)(struct wlr_renderer *renderer); - int (*get_drm_fd)(struct wlr_renderer *renderer); struct wlr_texture *(*texture_from_buffer)(struct wlr_renderer *renderer, struct wlr_buffer *buffer); struct wlr_render_pass *(*begin_buffer_pass)(struct wlr_renderer *renderer, diff --git a/include/wlr/render/pixman.h b/include/wlr/render/pixman.h index 206dd78c6..db38df11c 100644 --- a/include/wlr/render/pixman.h +++ b/include/wlr/render/pixman.h @@ -13,7 +13,6 @@ #include struct wlr_renderer *wlr_pixman_renderer_create(void); - bool wlr_renderer_is_pixman(struct wlr_renderer *wlr_renderer); bool wlr_texture_is_pixman(struct wlr_texture *texture); diff --git a/include/wlr/render/wlr_renderer.h b/include/wlr/render/wlr_renderer.h index a284005de..119313f88 100644 --- a/include/wlr/render/wlr_renderer.h +++ b/include/wlr/render/wlr_renderer.h @@ -55,6 +55,7 @@ struct wlr_renderer { struct { const struct wlr_renderer_impl *impl; + int drm_fd; } WLR_PRIVATE; }; diff --git a/render/gles2/renderer.c b/render/gles2/renderer.c index e362daee8..11e7544af 100644 --- a/render/gles2/renderer.c +++ b/render/gles2/renderer.c @@ -182,17 +182,6 @@ static const struct wlr_drm_format_set *gles2_get_render_formats( return wlr_egl_get_dmabuf_render_formats(renderer->egl); } -static int gles2_get_drm_fd(struct wlr_renderer *wlr_renderer) { - struct wlr_gles2_renderer *renderer = - gles2_get_renderer(wlr_renderer); - - if (renderer->drm_fd < 0) { - renderer->drm_fd = wlr_egl_dup_drm_fd(renderer->egl); - } - - return renderer->drm_fd; -} - struct wlr_egl *wlr_gles2_renderer_get_egl(struct wlr_renderer *wlr_renderer) { struct wlr_gles2_renderer *renderer = gles2_get_renderer(wlr_renderer); @@ -231,8 +220,8 @@ static void gles2_destroy(struct wlr_renderer *wlr_renderer) { wlr_drm_format_set_finish(&renderer->shm_texture_formats); - if (renderer->drm_fd >= 0) { - close(renderer->drm_fd); + if (wlr_renderer->drm_fd >= 0) { + close(wlr_renderer->drm_fd); } free(renderer); @@ -356,7 +345,6 @@ static const struct wlr_renderer_impl renderer_impl = { .destroy = gles2_destroy, .get_texture_formats = gles2_get_texture_formats, .get_render_formats = gles2_get_render_formats, - .get_drm_fd = gles2_get_drm_fd, .texture_from_buffer = gles2_texture_from_buffer, .begin_buffer_pass = gles2_begin_buffer_pass, .render_timer_create = gles2_render_timer_create, @@ -533,7 +521,7 @@ struct wlr_renderer *wlr_gles2_renderer_create(struct wlr_egl *egl) { renderer->egl = egl; renderer->exts_str = exts_str; - renderer->drm_fd = -1; + renderer->wlr_renderer.drm_fd = -1; wlr_log(WLR_INFO, "Creating GLES2 renderer"); wlr_log(WLR_INFO, "Using %s", glGetString(GL_VERSION)); @@ -683,7 +671,8 @@ struct wlr_renderer *wlr_gles2_renderer_create(struct wlr_egl *egl) { get_gles2_shm_formats(renderer, &renderer->shm_texture_formats); - int drm_fd = wlr_renderer_get_drm_fd(&renderer->wlr_renderer); + int drm_fd = wlr_egl_dup_drm_fd(renderer->egl); + renderer->wlr_renderer.drm_fd = drm_fd; uint64_t cap_syncobj_timeline; if (drm_fd >= 0 && drmGetCap(drm_fd, DRM_CAP_SYNCOBJ_TIMELINE, &cap_syncobj_timeline) == 0) { renderer->wlr_renderer.features.timeline = egl->procs.eglDupNativeFenceFDANDROID && diff --git a/render/pixman/renderer.c b/render/pixman/renderer.c index 4631a33ab..7d778dc9c 100644 --- a/render/pixman/renderer.c +++ b/render/pixman/renderer.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include #include @@ -252,6 +253,11 @@ static struct wlr_texture *pixman_texture_from_buffer( &data, &drm_format, &stride)) { return NULL; } + // This looks bad, because we're saying "end access" but also storing the + // pointer for later use. However, we only access the texture data from + // render_pass_add_texture() which does a begin/end access, and + // begin_pixman_data_ptr_access() will handle if the data pointer changes + // between accesses. So everything should be fine. wlr_buffer_end_data_ptr_access(buffer); struct wlr_pixman_texture *texture = pixman_texture_create(renderer, @@ -335,8 +341,9 @@ struct wlr_renderer *wlr_pixman_renderer_create(void) { const uint32_t *formats = get_pixman_drm_formats(&len); for (size_t i = 0; i < len; ++i) { - wlr_drm_format_set_add(&renderer->drm_formats, formats[i], - DRM_FORMAT_MOD_INVALID); + // Only support linear buffers. MOD_INVALID could mean the driver + // can do whatever it thinks appropriate, but pixman definitely + // only supports linear. wlr_drm_format_set_add(&renderer->drm_formats, formats[i], DRM_FORMAT_MOD_LINEAR); } diff --git a/render/vulkan/renderer.c b/render/vulkan/renderer.c index b2feca013..2e5258bd2 100644 --- a/render/vulkan/renderer.c +++ b/render/vulkan/renderer.c @@ -1153,6 +1153,11 @@ static void vulkan_destroy(struct wlr_renderer *wlr_renderer) { struct wlr_vk_instance *ini = dev->instance; vulkan_device_destroy(dev); vulkan_instance_destroy(ini); + + if (wlr_renderer->drm_fd > 0) { + close(wlr_renderer->drm_fd); + } + free(renderer); } @@ -1402,11 +1407,6 @@ destroy_image: return false; } -static int vulkan_get_drm_fd(struct wlr_renderer *wlr_renderer) { - struct wlr_vk_renderer *renderer = vulkan_get_renderer(wlr_renderer); - return renderer->dev->drm_fd; -} - static struct wlr_render_pass *vulkan_begin_buffer_pass(struct wlr_renderer *wlr_renderer, struct wlr_buffer *buffer, const struct wlr_buffer_pass_options *options) { struct wlr_vk_renderer *renderer = vulkan_get_renderer(wlr_renderer); @@ -1431,7 +1431,6 @@ static const struct wlr_renderer_impl renderer_impl = { .get_texture_formats = vulkan_get_texture_formats, .get_render_formats = vulkan_get_render_formats, .destroy = vulkan_destroy, - .get_drm_fd = vulkan_get_drm_fd, .texture_from_buffer = vulkan_texture_from_buffer, .begin_buffer_pass = vulkan_begin_buffer_pass, }; @@ -2442,7 +2441,8 @@ struct wlr_renderer *vulkan_renderer_create_for_device(struct wlr_vk_device *dev wl_list_init(&renderer->pipeline_layouts); uint64_t cap_syncobj_timeline; - if (dev->drm_fd >= 0 && drmGetCap(dev->drm_fd, DRM_CAP_SYNCOBJ_TIMELINE, &cap_syncobj_timeline) == 0) { + if (renderer->wlr_renderer.drm_fd >= 0 && + drmGetCap(renderer->wlr_renderer.drm_fd, DRM_CAP_SYNCOBJ_TIMELINE, &cap_syncobj_timeline) == 0) { renderer->wlr_renderer.features.timeline = dev->sync_file_import_export && cap_syncobj_timeline != 0; } @@ -2513,9 +2513,11 @@ struct wlr_renderer *wlr_vk_renderer_create_with_drm_fd(int drm_fd) { // Do not use the drm_fd that was passed in: we should prefer the render // node even if a primary node was provided - dev->drm_fd = vulkan_open_phdev_drm_fd(phdev); + int render_drm_fd = vulkan_open_phdev_drm_fd(phdev); - return vulkan_renderer_create_for_device(dev); + struct wlr_renderer *wlr_renderer = vulkan_renderer_create_for_device(dev); + wlr_renderer->drm_fd = render_drm_fd; + return wlr_renderer; } VkInstance wlr_vk_renderer_get_instance(struct wlr_renderer *renderer) { diff --git a/render/vulkan/vulkan.c b/render/vulkan/vulkan.c index 78bc25941..5bace73cc 100644 --- a/render/vulkan/vulkan.c +++ b/render/vulkan/vulkan.c @@ -458,7 +458,6 @@ struct wlr_vk_device *vulkan_device_create(struct wlr_vk_instance *ini, dev->phdev = phdev; dev->instance = ini; - dev->drm_fd = -1; // For dmabuf import we require at least the external_memory_fd, // external_memory_dma_buf, queue_family_foreign, @@ -665,10 +664,6 @@ void vulkan_device_destroy(struct wlr_vk_device *dev) { vkDestroyDevice(dev->dev, NULL); } - if (dev->drm_fd > 0) { - close(dev->drm_fd); - } - wlr_drm_format_set_finish(&dev->dmabuf_render_formats); wlr_drm_format_set_finish(&dev->dmabuf_texture_formats); wlr_drm_format_set_finish(&dev->shm_texture_formats); diff --git a/render/wlr_renderer.c b/render/wlr_renderer.c index e201a9c51..63b2bc903 100644 --- a/render/wlr_renderer.c +++ b/render/wlr_renderer.c @@ -267,6 +267,14 @@ static struct wlr_renderer *renderer_autocreate(struct wlr_backend *backend, int if ((is_auto && !has_render_node(backend)) || strcmp(renderer_name, "pixman") == 0) { renderer = wlr_pixman_renderer_create(); + if (open_preferred_drm_fd(backend, &drm_fd, &own_drm_fd)) { + wlr_log(WLR_DEBUG, "Creating pixman renderer with DRM FD %d", drm_fd); + renderer->drm_fd = drm_fd; + } else { + wlr_log(WLR_DEBUG, "Creating pixman renderer without DRM"); + renderer->drm_fd = -1; + } + if (renderer) { goto out; } else { @@ -297,11 +305,8 @@ struct wlr_renderer *wlr_renderer_autocreate(struct wlr_backend *backend) { return renderer_autocreate(backend, -1); } -int wlr_renderer_get_drm_fd(struct wlr_renderer *r) { - if (!r->impl->get_drm_fd) { - return -1; - } - return r->impl->get_drm_fd(r); +int wlr_renderer_get_drm_fd(struct wlr_renderer *renderer) { + return renderer->drm_fd; } struct wlr_render_pass *wlr_renderer_begin_buffer_pass(struct wlr_renderer *renderer,