mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-08 13:29:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xdg-popup: validate parent

Browse source 
This matches Mutter's behavior.

Fixes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3576
This commit is contained in:
Kirill Primak 2023-09-01 12:48:22 +03:00
parent 2926acf60d
commit e315068b98
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
types/xdg_shell/wlr_xdg_popup.c
View file

@ -376,6 +376,12 @@ void create_xdg_popup(struct wlr_xdg_surface *surface,
return; return;
} }
if (parent != NULL && parent->role == WLR_XDG_SURFACE_ROLE_NONE) {
wl_resource_post_error(surface->client->resource, XDG_WM_BASE_ERROR_INVALID_POPUP_PARENT,
"a popup parent must have a role");
return;
}
assert(surface->popup == NULL); assert(surface->popup == NULL);
surface->popup = calloc(1, sizeof(struct wlr_xdg_popup)); surface->popup = calloc(1, sizeof(struct wlr_xdg_popup));
if (!surface->popup) { if (!surface->popup) {