From d4e4c9f64b388cd2698294fbfcc37fd68104e24a Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Mon, 5 May 2025 22:14:40 +0200 Subject: [PATCH] render/vulkan: create binary semaphore when signal timeline is supplied We were only creating the binary semaphore when implicit sync interop was available. We also use the binary semaphore when explicit sync is enabled. Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3973 --- render/vulkan/pass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/render/vulkan/pass.c b/render/vulkan/pass.c index 032fcc7b2..3f662b203 100644 --- a/render/vulkan/pass.c +++ b/render/vulkan/pass.c @@ -480,7 +480,7 @@ static bool render_pass_submit(struct wlr_render_pass *wlr_pass) { .semaphore = renderer->timeline_semaphore, .value = render_timeline_point, }; - if (renderer->dev->implicit_sync_interop) { + if (renderer->dev->implicit_sync_interop || pass->signal_timeline != NULL) { if (render_cb->binary_semaphore == VK_NULL_HANDLE) { VkExportSemaphoreCreateInfo export_info = { .sType = VK_STRUCTURE_TYPE_EXPORT_SEMAPHORE_CREATE_INFO,