mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-10-29 05:40:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

output: rename impl->rollback to rollback_render

Browse source 
The output backend API is now mostly state-less thanks to the atomic
hooks (commit and test). There is one exception though: attach_render.
This function makes the rendering context current. However sometimes the
compositor might decide not to render after attach_render (e.g. when
there's nothing new to render to the back buffer). Thus
wlr_output_rollback has been introduced to revert the pending state.

Because the output backend API is mostly state-less, the only thing
wlr_output_impl.rollback needs to do is revert the current rendering
context. Rename the function to rollback_render to make this clear. Add
a check in the common wlr_output code to only call rollback_render when
attach_buffer has been previously called.

On the long term, we'll be able to remove attach_render and
rollback_render together.
This commit is contained in:
Simon Ser 2020-06-19 15:49:55 +02:00 • committed by Drew DeVault
parent 58df3eda9f
commit bf93d2e67c
6 changed files with 18 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
backend/x11/output.c
View file

@ -160,7 +160,7 @@ static bool output_commit(struct wlr_output *wlr_output) {
return true;
}
static void output_rollback(struct wlr_output *wlr_output) {
static void output_rollback_render(struct wlr_output *wlr_output) {
struct wlr_x11_output *output = get_x11_output_from_output(wlr_output);
wlr_egl_unset_current(&output->x11->egl);
}
@ -170,7 +170,7 @@ static const struct wlr_output_impl output_impl = {
.attach_render = output_attach_render,
.test = output_test,
.commit = output_commit,
.rollback = output_rollback,
.rollback_render = output_rollback_render,
};
struct wlr_output *wlr_x11_output_create(struct wlr_backend *backend) {