mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-03 09:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #1689 RDP RemoteFX crash

Browse source 
When using the rdp backend and connecting with xfreerdp ... --rfx, wlroots
crashes in backend/rdp/output.c while attempting to realloc(..., 0).

This commit guards against that and instead returns true, resulting in
no rfx message being sent. This prevents the crash and appears to work, but
it's not obvious if this is correct from a specification perspective.
This commit is contained in:
Michiel 2019-05-05 20:24:16 +01:00 • committed by Simon Ser
parent 03346cb28f
commit a68c7c0c8d
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
backend/rdp/output.c
View file

@ -79,6 +79,9 @@ static bool output_attach_render(struct wlr_output *wlr_output,
static bool rfx_swap_buffers( static bool rfx_swap_buffers(
struct wlr_rdp_output *output, pixman_region32_t *damage) { struct wlr_rdp_output *output, pixman_region32_t *damage) {
if (!pixman_region32_not_empty(damage)) {
return true;
}
struct wlr_rdp_peer_context *context = output->context; struct wlr_rdp_peer_context *context = output->context;
freerdp_peer *peer = context->peer; freerdp_peer *peer = context->peer;
rdpUpdate *update = peer->update; rdpUpdate *update = peer->update;