mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-23 06:59:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xdg-shell: don't populate current state on ack_configure

Browse source 
The xdg_surface.ack_configure request is double-buffered state.
We shouldn't apply it immediately, we should wait for the surface
commit to be applied.
This commit is contained in:
Simon Ser 2021-07-06 19:46:52 +02:00
parent 9c3163df7a
commit 8e91913452
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/wlr/types/wlr_xdg_shell.h
View file

@ -150,6 +150,7 @@ struct wlr_xdg_surface_configure {
};
struct wlr_xdg_surface_state {
uint32_t configure_serial;
bool has_geometry;
struct wlr_box geometry;

3
types/xdg_shell/wlr_xdg_surface.c
View file

@ -142,7 +142,7 @@ static void xdg_surface_handle_ack_configure(struct wl_client *client,
}
surface->configured = true;
surface->configure_serial = serial;
surface->pending.configure_serial = serial;
wlr_signal_emit_safe(&surface->events.ack_configure, configure);
xdg_surface_configure_destroy(configure);
@ -401,6 +401,7 @@ void handle_xdg_surface_commit(struct wlr_surface *wlr_surface) {
return;
}
surface->configure_serial = next.configure_serial;
if (next.has_geometry) {
surface->geometry = next.geometry;
}