idle-inhibit: second feedback pass

This commit is contained in:
Markus Ongyerth 2018-02-21 16:17:59 +01:00
parent 3016133f91
commit 87a7afb641
4 changed files with 81 additions and 55 deletions

View file

@ -19,17 +19,16 @@ wlr_idle_inhibit_manager_v1_from_resource(struct wl_resource *resource) {
return wl_resource_get_user_data(resource);
}
struct wlr_idle_inhibit_inhibitor_v1 *
wlr_idle_inhibit_inhibitor_v1_from_resource(struct wl_resource *resource) {
struct wlr_idle_inhibitor_v1 *
wlr_idle_inhibitor_v1_from_resource(struct wl_resource *resource) {
assert(wl_resource_instance_of(resource, &zwp_idle_inhibitor_v1_interface,
&idle_inhibitor_impl));
return wl_resource_get_user_data(resource);
}
static void idle_inhibit_inhibitor_destroy(struct wl_resource *resource) {
struct wlr_idle_inhibit_inhibitor_v1 *inhibitor =
wlr_idle_inhibit_inhibitor_v1_from_resource(resource);
assert(inhibitor);
static void idle_inhibitor_destroy(struct wl_resource *resource) {
struct wlr_idle_inhibitor_v1 *inhibitor =
wlr_idle_inhibitor_v1_from_resource(resource);
wlr_signal_emit_safe(&inhibitor->events.destroy, inhibitor->surface);
@ -38,21 +37,21 @@ static void idle_inhibit_inhibitor_destroy(struct wl_resource *resource) {
free(inhibitor);
}
static void idle_inhibit_inhibitor_handle_surface_destroy(
static void idle_inhibitor_handle_surface_destroy(
struct wl_listener *listener, void *data) {
struct wlr_idle_inhibit_inhibitor_v1 *inhibitor =
struct wlr_idle_inhibitor_v1 *inhibitor =
wl_container_of(listener, inhibitor, surface_destroy);
wl_resource_destroy(inhibitor->resource);
}
static void idle_inhibit_inhibitor_v1_handle_destroy(struct wl_client *client,
static void idle_inhibitor_v1_handle_destroy(struct wl_client *client,
struct wl_resource *manager_resource) {
wl_resource_destroy(manager_resource);
}
static struct zwp_idle_inhibitor_v1_interface idle_inhibitor_impl = {
.destroy = idle_inhibit_inhibitor_v1_handle_destroy,
.destroy = idle_inhibitor_v1_handle_destroy,
};
static void wlr_create_inhibitor(struct wl_client *client,
@ -61,10 +60,9 @@ static void wlr_create_inhibitor(struct wl_client *client,
struct wlr_surface *surface = wlr_surface_from_resource(surface_resource);
struct wlr_idle_inhibit_manager_v1 *manager =
wlr_idle_inhibit_manager_v1_from_resource(resource);
assert(surface && manager);
struct wlr_idle_inhibit_inhibitor_v1 *inhibitor =
calloc(1, sizeof(struct wlr_idle_inhibit_inhibitor_v1));
struct wlr_idle_inhibitor_v1 *inhibitor =
calloc(1, sizeof(struct wlr_idle_inhibitor_v1));
if (!inhibitor) {
wl_client_post_no_memory(client);
return;
@ -82,12 +80,12 @@ static void wlr_create_inhibitor(struct wl_client *client,
inhibitor->surface = surface;
wl_signal_init(&inhibitor->events.destroy);
inhibitor->surface_destroy.notify = idle_inhibit_inhibitor_handle_surface_destroy;
inhibitor->surface_destroy.notify = idle_inhibitor_handle_surface_destroy;
wl_signal_add(&surface->events.destroy, &inhibitor->surface_destroy);
wl_resource_set_implementation(wl_resource, &idle_inhibitor_impl,
inhibitor, idle_inhibit_inhibitor_destroy);
inhibitor, idle_inhibitor_destroy);
wl_list_insert(&manager->inhibitors, &inhibitor->link);
wlr_signal_emit_safe(&manager->events.new_inhibitor, inhibitor);
@ -118,7 +116,6 @@ static void handle_display_destroy(struct wl_listener *listener, void *data) {
static void idle_inhibit_bind(struct wl_client *wl_client, void *data,
uint32_t version, uint32_t id) {
struct wlr_idle_inhibit_manager_v1 *idle_inhibit = data;
assert(wl_client && idle_inhibit);
struct wl_resource *wl_resource = wl_resource_create(wl_client,
&zwp_idle_inhibit_manager_v1_interface, version, id);
@ -142,8 +139,8 @@ void wlr_idle_inhibit_v1_destroy(struct wlr_idle_inhibit_manager_v1 *idle_inhibi
wl_list_remove(&idle_inhibit->display_destroy.link);
struct wlr_idle_inhibit_inhibitor_v1 *inhibitor;
struct wlr_idle_inhibit_inhibitor_v1 *tmp;
struct wlr_idle_inhibitor_v1 *inhibitor;
struct wlr_idle_inhibitor_v1 *tmp;
wl_list_for_each_safe(inhibitor, tmp, &idle_inhibit->inhibitors, link) {
wl_resource_destroy(inhibitor->resource);
}