mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-10-29 05:40:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

render/vulkan: use sRGB image view when color transform is set

Browse source 
If the color transform is set to sRGB inverse EOTF, we can use the
sRGB image view just like when no color transform is passed in.
This commit is contained in:
Simon Ser 2025-06-21 17:07:00 +02:00
parent 54374b6fe6
commit 7f6d66ea62
1 changed files with 26 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

39
render/vulkan/pass.c
View file

@ -1177,28 +1177,41 @@ static const struct wlr_addon_interface vk_color_transform_impl = {
struct wlr_vk_render_pass *vulkan_begin_render_pass(struct wlr_vk_renderer *renderer,
struct wlr_vk_render_buffer *buffer, const struct wlr_buffer_pass_options *options) {
bool using_srgb_pathway;
uint32_t inv_eotf;
if (options != NULL && options->color_transform != NULL) {
using_srgb_pathway = false;
if (options->color_transform->type == COLOR_TRANSFORM_INVERSE_EOTF) {
struct wlr_color_transform_inverse_eotf *tr =
wlr_color_transform_inverse_eotf_from_base(options->color_transform);
inv_eotf = tr->tf;
} else {
// Color transform is not an inverse EOTF
inv_eotf = 0;
}
} else {
// This is the default when unspecified
inv_eotf = WLR_COLOR_TRANSFER_FUNCTION_SRGB;
}
if (!get_color_transform(options->color_transform, renderer)) {
bool using_srgb_pathway = inv_eotf == WLR_COLOR_TRANSFER_FUNCTION_SRGB &&
buffer->srgb.framebuffer != VK_NULL_HANDLE;
if (!using_srgb_pathway) {
if (options != NULL && options->color_transform != NULL &&
!get_color_transform(options->color_transform, renderer)) {
/* Try to create a new color transform */
if (!vk_color_transform_create(renderer, options->color_transform)) {
wlr_log(WLR_ERROR, "Failed to create color transform");
return NULL;
}
}
} else {
// Use srgb pathway if it is the default/has already been set up
using_srgb_pathway = buffer->srgb.framebuffer != VK_NULL_HANDLE;
}
if (!using_srgb_pathway && !buffer->two_pass.image_view) {
struct wlr_dmabuf_attributes attribs;
wlr_buffer_get_dmabuf(buffer->wlr_buffer, &attribs);
if (!vulkan_setup_two_pass_framebuffer(buffer, &attribs)) {
wlr_log(WLR_ERROR, "Failed to set up blend image");
return NULL;
if (!buffer->two_pass.image_view) {
struct wlr_dmabuf_attributes attribs;
wlr_buffer_get_dmabuf(buffer->wlr_buffer, &attribs);
if (!vulkan_setup_two_pass_framebuffer(buffer, &attribs)) {
wlr_log(WLR_ERROR, "Failed to set up blend image");
return NULL;
}
}
}