mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-14 06:59:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

backend/drm: fix frame scheduling on secondary GPUs

Browse source 
There was a missing copy_drm_surface_mgpu call in drm_connector_schedule_frame
so we asked for a pageflip with an unknown BO, resulting in ENOENT.

Additionally, this commit makes schedule_frame return a bool indicating
failures. This allows schedule_frame_handle_idle_timer to only set
frame_pending to true if a frame has been successfully scheduled. Thus, if a
pageflip fails, rendering won't be blocked forever anymore.

In case a pageflip is already pending, true is returned because a frame has
already been scheduled and will be sent sometime soon.
This commit is contained in:
emersion 2018-10-29 20:38:57 +01:00
parent 659d39baaa
commit 68362b37a8
No known key found for this signature in database
GPG key ID: 0FDE7BE0E88F5E48
4 changed files with 17 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
types/wlr_output.c
View file

@ -547,8 +547,9 @@ static void schedule_frame_handle_idle_timer(void *data) {
output->idle_frame = NULL;
if (!output->frame_pending && output->impl->schedule_frame) {
// Ask the backend to send a frame event when appropriate
output->frame_pending = true;
output->impl->schedule_frame(output);
if (output->impl->schedule_frame(output)) {
output->frame_pending = true;
}
}
}