mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2026-02-04 04:06:09 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ext_image_copy_capture_v1: Only render scene source on damage

Browse source 
wlr_scene_output_needs_frame checks wlr_output.needs_frame and
wlr_scene_output.gamma_lut_changed, neither of which incur damage. The
needs_frame flag is often set by e.g., cursor movement.

For the purpose of a capture frame we are only interested in frames with
damage. Continue without damage causes session_handle_source_frame to
silently skip copying the frame, which causes the session to get stuck:
no ready or failed event is emitted, and frame_pending is still set so
no further output frame events will occur.

Only render in case there is damage, but send frame callbacks
regardless.
This commit is contained in:
Kenny Levinsen 2026-01-15 15:22:27 +01:00 • committed by Simon Ser
parent 5a40da7e15
commit 5e32b6663b
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
types/ext_image_capture_source_v1/scene.c
View file

@ -95,10 +95,6 @@ static void source_render(struct scene_node_source *source) {
// TODO: send failure
return;
}
struct timespec now;
clock_gettime(CLOCK_MONOTONIC, &now);
wlr_scene_output_send_frame_done(scene_output, &now);
}
static void source_start(struct wlr_ext_image_capture_source_v1 *base, bool with_cursors) {
@ -110,6 +106,10 @@ static void source_start(struct wlr_ext_image_capture_source_v1 *base, bool with
}
source_render(source);
struct timespec now;
clock_gettime(CLOCK_MONOTONIC, &now);
wlr_scene_output_send_frame_done(source->scene_output, &now);
}
static void source_stop(struct wlr_ext_image_capture_source_v1 *base) {
@ -285,7 +285,14 @@ static void source_handle_output_frame(struct wl_listener *listener, void *data)
return;
}
source_render(source);
// We can only emit frames with damage
if (!pixman_region32_empty(&source->scene_output->pending_commit_damage)) {
source_render(source);
}
struct timespec now;
clock_gettime(CLOCK_MONOTONIC, &now);
wlr_scene_output_send_frame_done(source->scene_output, &now);
}
struct wlr_ext_image_capture_source_v1 *wlr_ext_image_capture_source_v1_create_with_scene_node(