mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-02 09:01:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

backend/drm/atomic: Always use BT.709 encoding for YUV

Browse source 
When we overlay/scanout non-RGB planes we were relying on the default
DRM color encoding, which could vary per DRM device.  We want this to be
consistent across devices and with YUV conversion done by renderers, so
change this to always use BT.709 encoding (if the property is
available).  I've chosen BT.709 because it should be correct for HD
video, which is probably most common.
This commit is contained in:
David Turner 2025-05-08 09:53:24 +01:00
parent 2420bfef0b
commit 5234e30578
3 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
backend/drm/atomic.c
View file

@ -378,6 +378,15 @@ static void set_plane_props(struct atomic *atom, struct wlr_drm_backend *drm,
atomic_add(atom, id, props->crtc_y, dst_box->y);
atomic_add(atom, id, props->crtc_w, dst_box->width);
atomic_add(atom, id, props->crtc_h, dst_box->height);
// Always set the color encoding on every plane to BT.709. This only
// affects YUV planes (eg. scanout video). This won't be correct for
// all video but at least means we will be consistent and most
// importantly should match the GLES2 renderer, so avoids visible
// color-shifts when direct scanout is enabled/disabled.
if (props->color_encoding) {
atomic_add(atom, id, props->color_encoding, DRM_COLOR_YCBCR_BT709);
}
}
static bool supports_cursor_hotspots(const struct wlr_drm_plane *plane) {

1
backend/drm/properties.c
View file

@ -48,6 +48,7 @@ static const struct prop_info crtc_info[] = {
static const struct prop_info plane_info[] = {
#define INDEX(name) (offsetof(struct wlr_drm_plane_props, name) / sizeof(uint32_t))
{ "COLOR_ENCODING", INDEX(color_encoding) },
{ "CRTC_H", INDEX(crtc_h) },
{ "CRTC_ID", INDEX(crtc_id) },
{ "CRTC_W", INDEX(crtc_w) },

12
include/backend/drm/properties.h
View file

@ -63,6 +63,18 @@ struct wlr_drm_plane_props {
uint32_t hotspot_x;
uint32_t hotspot_y;
uint32_t in_fence_fd;
uint32_t color_encoding; // Not guaranteed to exist
};
/*
* The encoding and range enums are defined in the kernel but not
* exposed in public headers.
*/
enum drm_color_encoding {
DRM_COLOR_YCBCR_BT601,
DRM_COLOR_YCBCR_BT709,
DRM_COLOR_YCBCR_BT2020,
};
bool get_drm_connector_props(int fd, uint32_t id,