mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-02 09:01:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

render/vulkan: Avoid double-free on calloc error

Browse source 
In query_modifier_support, the calloc for either or both of render_mods
and texture_mods may fail, in which case both are freed for convenience.
However, if one is non-NULL, vulkan_format_props_finish will try to free
it again.

NULL them to avoid double-free.
This commit is contained in:
Kenny Levinsen 2024-02-22 23:07:58 +01:00
parent 73dd934794
commit 4d68d3759b
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/vulkan/pixel_format.c
View file

@ -401,6 +401,8 @@ static bool query_modifier_support(struct wlr_vk_device *dev,
free(modp.pDrmFormatModifierProperties); free(modp.pDrmFormatModifierProperties);
free(props->dmabuf.render_mods); free(props->dmabuf.render_mods);
free(props->dmabuf.texture_mods); free(props->dmabuf.texture_mods);
props->dmabuf.render_mods = NULL;
props->dmabuf.texture_mods = NULL;
return false; return false;
} }