mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2026-03-17 05:34:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

scene: use wl_list_for_each_safe to iterate outputs

Browse source 
The outputs loop in handle_scene_buffer_outputs_update may remove entries
from the list while iterating, so use wl_list_for_each_safe instead of
wl_list_for_each.

Fixes: 39e918edc8 ("scene: avoid redundant wl_surface.enter/leave events")
This commit is contained in:
llyyr 2026-03-13 23:32:06 +05:30
parent 7f87c7fe90
commit 3cb2cf9425
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
types/scene/surface.c
View file

@ -112,8 +112,8 @@ static void handle_scene_buffer_outputs_update(
// 2. When a surface transitions from being visible on 0 outputs to being visible on >0 outputs
// send leave events for all entered outputs on which the surface is no longer visible as
// well as enter events for any outputs not already entered.
struct wlr_surface_output *entered_output;
wl_list_for_each(entered_output, &surface->surface->current_outputs, link) {
struct wlr_surface_output *entered_output, *tmp;
wl_list_for_each_safe(entered_output, tmp, &surface->surface->current_outputs, link) {
bool active = false;
for (size_t i = 0; i < event->size; i++) {
if (entered_output->output == event->active[i]->output) {