mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-03 09:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

output: reset the pending state on failed commit

Browse source 
It can be surprising for callers to stash pending changes, commit, get a
failure, then set some other pending changes, commit again, and get another
failure because of the previously-pending changes.

Instead, make commit reset the pending state on failure.
This commit is contained in:
Simon Ser 2019-06-16 10:19:34 +03:00 • committed by Drew DeVault
parent 06a13203dd
commit 33127c545b
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
types/wlr_output.c
View file

@ -472,6 +472,7 @@ bool wlr_output_commit(struct wlr_output *output) {
wlr_signal_emit_safe(&output->events.precommit, &event); wlr_signal_emit_safe(&output->events.precommit, &event);
if (!output->impl->commit(output)) { if (!output->impl->commit(output)) {
output_state_clear(&output->pending);
return false; return false;
} }