From 2d5492c73770c9de420527df1098fefabe43d689 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Thu, 10 Apr 2025 14:46:35 +0200 Subject: [PATCH] text-input-v3: Use `NULL` when emitting signals MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Listeners can use `wl_container_of`. Helps: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3851 Signed-off-by: Guido Günther --- types/wlr_text_input_v3.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/types/wlr_text_input_v3.c b/types/wlr_text_input_v3.c index 1b1ea4df9..bbae3a076 100644 --- a/types/wlr_text_input_v3.c +++ b/types/wlr_text_input_v3.c @@ -64,7 +64,7 @@ void wlr_text_input_v3_send_done(struct wlr_text_input_v3 *text_input) { } static void wlr_text_input_destroy(struct wlr_text_input_v3 *text_input) { - wl_signal_emit_mutable(&text_input->events.destroy, text_input); + wl_signal_emit_mutable(&text_input->events.destroy, NULL); assert(wl_list_empty(&text_input->events.enable.listener_list)); assert(wl_list_empty(&text_input->events.commit.listener_list)); @@ -192,12 +192,12 @@ static void text_input_commit(struct wl_client *client, if (!old_enabled && text_input->current_enabled) { text_input->active_features = text_input->current.features; - wl_signal_emit_mutable(&text_input->events.enable, text_input); + wl_signal_emit_mutable(&text_input->events.enable, NULL); } else if (old_enabled && !text_input->current_enabled) { text_input->active_features = 0; - wl_signal_emit_mutable(&text_input->events.disable, text_input); + wl_signal_emit_mutable(&text_input->events.disable, NULL); } else { // including never enabled - wl_signal_emit_mutable(&text_input->events.commit, text_input); + wl_signal_emit_mutable(&text_input->events.commit, NULL); } } @@ -313,7 +313,7 @@ static void text_input_manager_bind(struct wl_client *wl_client, void *data, static void handle_display_destroy(struct wl_listener *listener, void *data) { struct wlr_text_input_manager_v3 *manager = wl_container_of(listener, manager, display_destroy); - wl_signal_emit_mutable(&manager->events.destroy, manager); + wl_signal_emit_mutable(&manager->events.destroy, NULL); assert(wl_list_empty(&manager->events.new_text_input.listener_list)); assert(wl_list_empty(&manager->events.destroy.listener_list));