mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-11-01 22:58:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

output: allow_artifacts -> allow_reconfiguration

Browse source 
The name "allow_artifacts" and associated description is very vague, and
theoretically allow for tearing behavior. Clarify that we only intend to
mean artifacts related to output configuration (e.g., modesets).

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3740
This commit is contained in:
Kenny Levinsen 2023-10-06 00:14:32 +02:00 • committed by Simon Ser
parent 291431c14f
commit 2cf78f4c5b
4 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
types/output/render.c
View file

@ -155,7 +155,7 @@ bool output_ensure_buffer(struct wlr_output *output,
if (state->committed & WLR_OUTPUT_STATE_RENDER_FORMAT) {
needs_new_buffer = true;
}
if (state->allow_artifacts && output->commit_seq == 0 && enabled) {
if (state->allow_reconfiguration && output->commit_seq == 0 && enabled) {
// On first commit, require a new buffer if the compositor called a
// mode-setting function, even if the mode won't change. This makes it
// so the swapchain is created now.

6
types/output/state.c
View file

@ -22,7 +22,7 @@ void wlr_output_state_set_enabled(struct wlr_output_state *state,
bool enabled) {
state->committed |= WLR_OUTPUT_STATE_ENABLED;
state->enabled = enabled;
state->allow_artifacts = true;
state->allow_reconfiguration = true;
}
void wlr_output_state_set_mode(struct wlr_output_state *state,
@ -30,7 +30,7 @@ void wlr_output_state_set_mode(struct wlr_output_state *state,
state->committed |= WLR_OUTPUT_STATE_MODE;
state->mode_type = WLR_OUTPUT_STATE_MODE_FIXED;
state->mode = mode;
state->allow_artifacts = true;
state->allow_reconfiguration = true;
}
void wlr_output_state_set_custom_mode(struct wlr_output_state *state,
@ -40,7 +40,7 @@ void wlr_output_state_set_custom_mode(struct wlr_output_state *state,
state->custom_mode.width = width;
state->custom_mode.height = height;
state->custom_mode.refresh = refresh;
state->allow_artifacts = true;
state->allow_reconfiguration = true;
}
void wlr_output_state_set_scale(struct wlr_output_state *state, float scale) {