mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-10-29 05:40:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

render/drm_format_set: fix corruption in wlr_drm_format_set_remove()

Browse source 
A single byte was moved instead of a full uint64_t. This results
in corrupted lists containing bogus modifiers.
This commit is contained in:
Simon Ser 2024-11-28 20:00:36 +01:00 • committed by Kenny Levinsen
parent e21899037a
commit 2424b1ecdd
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/drm_format_set.c
View file

@ -95,7 +95,7 @@ bool wlr_drm_format_set_remove(struct wlr_drm_format_set *set, uint32_t format,
for (size_t idx = 0; idx < fmt->len; idx++) {
if (fmt->modifiers[idx] == modifier) {
memmove(&fmt->modifiers[idx], &fmt->modifiers[idx+1], fmt->len - idx - 1);
memmove(&fmt->modifiers[idx], &fmt->modifiers[idx+1], (fmt->len - idx - 1) * sizeof(fmt->modifiers[0]));
fmt->len--;
return true;
}