mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2026-04-18 06:47:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

compositor: wrap cached lock seq in struct

Browse source 
This improves type safety: the struct wlr_surface_cached_lock value
can't be mixed with other integer values.
This commit is contained in:
Simon Ser 2023-12-22 10:07:04 +01:00
parent f3e1f7b2a7
commit 15b0adf59a
4 changed files with 20 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
include/wlr/types/wlr_compositor.h
View file

@ -381,6 +381,13 @@ void wlr_surface_get_effective_damage(struct wlr_surface *surface,
void wlr_surface_get_buffer_source_box(struct wlr_surface *surface,
struct wlr_fbox *box);
/**
* A lock preventing cached state from being applied.
*/
struct wlr_surface_cached_lock {
uint32_t seq;
};
/**
* Acquire a lock for the pending surface state.
*
@ -390,7 +397,7 @@ void wlr_surface_get_buffer_source_box(struct wlr_surface *surface,
*
* Returns a surface commit sequence number for the cached state.
*/
uint32_t wlr_surface_lock_pending(struct wlr_surface *surface);
struct wlr_surface_cached_lock wlr_surface_lock_pending(struct wlr_surface *surface);
/**
* Release a lock for a cached state.
@ -398,7 +405,7 @@ uint32_t wlr_surface_lock_pending(struct wlr_surface *surface);
* Callers should not assume that the cached state will immediately be
* committed. Another caller may still have an active lock.
*/
void wlr_surface_unlock_cached(struct wlr_surface *surface, uint32_t seq);
void wlr_surface_unlock_cached(struct wlr_surface *surface, struct wlr_surface_cached_lock lock);
/**
* Set the preferred buffer scale for the surface.

2
include/wlr/types/wlr_subcompositor.h
View file

@ -32,7 +32,7 @@ struct wlr_subsurface {
struct wlr_subsurface_parent_state current, pending;
uint32_t cached_seq;
struct wlr_surface_cached_lock cached_lock;
bool has_cache;
bool synchronized;

10
types/wlr_compositor.c
View file

@ -815,13 +815,13 @@ static void surface_destroy_role_object(struct wlr_surface *surface) {
wl_list_init(&surface->role_resource_destroy.link);
}
uint32_t wlr_surface_lock_pending(struct wlr_surface *surface) {
struct wlr_surface_cached_lock wlr_surface_lock_pending(struct wlr_surface *surface) {
surface->pending.cached_state_locks++;
return surface->pending.seq;
return (struct wlr_surface_cached_lock){surface->pending.seq};
}
void wlr_surface_unlock_cached(struct wlr_surface *surface, uint32_t seq) {
if (surface->pending.seq == seq) {
void wlr_surface_unlock_cached(struct wlr_surface *surface, struct wlr_surface_cached_lock lock) {
if (surface->pending.seq == lock.seq) {
assert(surface->pending.cached_state_locks > 0);
surface->pending.cached_state_locks--;
return;
@ -830,7 +830,7 @@ void wlr_surface_unlock_cached(struct wlr_surface *surface, uint32_t seq) {
bool found = false;
struct wlr_surface_state *cached;
wl_list_for_each(cached, &surface->cached, cached_state_link) {
if (cached->seq == seq) {
if (cached->seq == lock.seq) {
found = true;
break;
}

10
types/wlr_subcompositor.c
View file

@ -26,7 +26,7 @@ static const struct wl_subsurface_interface subsurface_implementation;
static void subsurface_destroy(struct wlr_subsurface *subsurface) {
if (subsurface->has_cache) {
wlr_surface_unlock_cached(subsurface->surface, subsurface->cached_seq);
wlr_surface_unlock_cached(subsurface->surface, subsurface->cached_lock);
}
wlr_surface_unmap(subsurface->surface);
@ -177,7 +177,7 @@ static void subsurface_handle_set_desync(struct wl_client *client,
if (!subsurface_is_synchronized(subsurface) &&
subsurface->has_cache) {
wlr_surface_unlock_cached(subsurface->surface,
subsurface->cached_seq);
subsurface->cached_lock);
subsurface->has_cache = false;
}
}
@ -247,9 +247,9 @@ static void subsurface_handle_surface_client_commit(
return;
}
subsurface->has_cache = true;
subsurface->cached_seq = wlr_surface_lock_pending(surface);
subsurface->cached_lock = wlr_surface_lock_pending(surface);
} else if (subsurface->has_cache) {
wlr_surface_unlock_cached(surface, subsurface->cached_seq);
wlr_surface_unlock_cached(surface, subsurface->cached_lock);
subsurface->has_cache = false;
}
}
@ -275,7 +275,7 @@ void subsurface_handle_parent_commit(struct wlr_subsurface *subsurface) {
}
if (subsurface->synchronized && subsurface->has_cache) {
wlr_surface_unlock_cached(surface, subsurface->cached_seq);
wlr_surface_unlock_cached(surface, subsurface->cached_lock);
subsurface->has_cache = false;
}