mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2026-02-16 22:05:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xwayland: listen for wlr_drag destroy

Browse source
This commit is contained in:
emersion 2018-05-19 17:12:01 +01:00
parent 6ad84242df
commit 12a37d666c
No known key found for this signature in database
GPG key ID: 0FDE7BE0E88F5E48
2 changed files with 36 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/xwayland/xwm.h
View file

@ -117,6 +117,7 @@ struct wlr_xwm {
struct wl_list unpaired_surfaces; // wlr_xwayland_surface::unpaired_link
struct wlr_drag *incoming_drag;
struct wlr_drag *drag;
struct wlr_xwayland_surface *drag_focus;
@ -135,6 +136,7 @@ struct wlr_xwm {
struct wl_listener seat_drag_drop;
struct wl_listener seat_drag_destroy;
struct wl_listener seat_drag_source_destroy;
struct wl_listener incoming_drag_destroy;
};
struct wlr_xwm *xwm_create(struct wlr_xwayland *wlr_xwayland);

66
xwayland/selection/dnd.c
View file

@ -320,6 +320,19 @@ error:
return false;
}
static void incoming_drag_handle_destroy(struct wl_listener *listener,
void *data) {
struct wlr_xwm *xwm = wl_container_of(listener, xwm, incoming_drag_destroy);
static const uint32_t values[] = { XCB_STACK_MODE_BELOW };
xcb_configure_window(xwm->xcb_conn, xwm->dnd_window,
XCB_CONFIG_WINDOW_STACK_MODE, values);
xcb_unmap_window(xwm->xcb_conn, xwm->dnd_window);
wl_list_remove(&xwm->incoming_drag_destroy.link);
xwm->incoming_drag = NULL;
}
/**
* Handle an enter message for an incoming DnD operation.
*/
@ -339,18 +352,19 @@ static void xwm_handle_dnd_enter(struct wlr_xwm *xwm,
return;
}
if (xwm->incoming_drag == NULL) {
if (xwm->incoming_drag != NULL) {
wlr_log(L_DEBUG, "ignoring XdndEnter client message because "
"no xwayland drag is being performed");
"another xwayland drag is being performed");
return;
}
struct wlr_xwayland_data_source *source =
xwayland_data_source_from_wlr_data_source(xwm->incoming_drag->source);
struct wlr_seat *seat = xwm->seat;
struct wlr_seat_client *seat_client =
wlr_seat_client_for_wl_client(seat, xwm->xwayland->client);
if (source->base.mime_types.size > 0) {
wlr_log(L_DEBUG, "ignoring XdndEnter client message because "
"it has already been received");
struct wlr_xwayland_data_source *source =
xwayland_data_source_create(&xwm->dnd_selection);
if (source == NULL) {
return;
}
@ -374,6 +388,17 @@ static void xwm_handle_dnd_enter(struct wlr_xwm *xwm,
}
}
// TODO: set the icon?
xwm->incoming_drag =
wlr_seat_client_start_grab(seat_client, &source->base, NULL, NULL);
if (xwm->incoming_drag == NULL) {
wlr_log(L_ERROR, "could not start grab");
}
wl_signal_add(&xwm->incoming_drag->events.destroy,
&xwm->incoming_drag_destroy);
xwm->incoming_drag_destroy.notify = incoming_drag_handle_destroy;
wlr_log(L_DEBUG, "DND_ENTER window=%d", source_window);
}
@ -399,7 +424,7 @@ static void xwm_handle_dnd_position(struct wlr_xwm *xwm,
}
if (xwm->incoming_drag == NULL) {
wlr_log(L_DEBUG, "ignoring XdndEnter client message because "
wlr_log(L_DEBUG, "ignoring XdndPosition client message because "
"no xwayland drag is being performed");
return;
}
@ -453,32 +478,9 @@ int xwm_dnd_handle_xfixes_selection_notify(struct wlr_xwm *xwm,
xcb_configure_window(xwm->xcb_conn, xwm->dnd_window,
XCB_CONFIG_WINDOW_STACK_MODE, values);
struct wlr_seat *seat = selection->xwm->seat;
struct wlr_seat_client *seat_client = wlr_seat_client_for_wl_client(
seat, selection->xwm->xwayland->client);
struct wlr_xwayland_data_source *source =
xwayland_data_source_create(selection);
if (source == NULL) {
return 0;
}
// TODO: send motion events to DND window
selection->xwm->incoming_drag =
wlr_seat_client_start_grab(seat_client, &source->base, NULL, NULL);
if (selection->xwm->incoming_drag == NULL) {
wlr_log(L_ERROR, "could not start grab");
}
// Let's wait for the DND_ENTER message
} else {
wlr_log(L_INFO, "end grab");
static const uint32_t values[] = { XCB_STACK_MODE_BELOW };
xcb_configure_window(xwm->xcb_conn, xwm->dnd_window,
XCB_CONFIG_WINDOW_STACK_MODE, values);
xcb_unmap_window(xwm->xcb_conn, xwm->dnd_window);
// TODO: drag_end(selection->xwm->incoming_drag)
selection->xwm->incoming_drag = NULL;
}
return 1;