mirror of
https://gitlab.freedesktop.org/wayland/wayland.git
synced 2025-10-29 05:40:16 -04:00
8a7ecd774c
If a wl_array has size zero, wl_array_for_each computes NULL + 0 to get to the end pointer. This should be fine, and indeed it would be fine in C++. But the C specification has a mistake here and it is actually undefined behavior. See https://davidben.net/2024/01/15/empty-slices.html Clang's -fsanitize=undefined flags this. I ran into this in Chromium's build with wayland-scanner on one of our XML files. ../../third_party/wayland/src/src/scanner.c:1853:2: runtime error: applying zero offset to null pointer #0 0x55c979b8e02c in emit_code third_party/wayland/src/src/scanner.c:1853:2 #1 0x55c979b89323 in main third_party/wayland/src/src/scanner.c #2 0x7f8dfdb8c6c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #3 0x7f8dfdb8c784 in __libc_start_main csu/../csu/libc-start.c:360:3 #4 0x55c979b70f39 in _start (...) An empty XML file is sufficient to hit this case, so I've added it as a test. To reproduce, undo the fix and include only the test, then build with: CC=clang CFLAGS="-fno-sanitize-recover=undefined" meson build/ -Db_sanitize=undefined -Db_lundef=false ninja -C build test Signed-off-by: David Benjamin <davidben@google.com>
82 lines
2.7 KiB
Bash
Executable file
82 lines
2.7 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
echo "srcdir: $srcdir"
|
|
echo "scanner: $WAYLAND_SCANNER"
|
|
echo "test_data_dir: $TEST_DATA_DIR"
|
|
echo "test_output_dir: $TEST_OUTPUT_DIR"
|
|
echo "pwd: $PWD"
|
|
echo "sed: $SED"
|
|
|
|
RETCODE=0
|
|
|
|
hard_fail() {
|
|
echo "$@" "ERROR"
|
|
exit 99
|
|
}
|
|
|
|
fail() {
|
|
echo "$@" "FAIL"
|
|
RETCODE=1
|
|
}
|
|
|
|
mkdir -p "$TEST_OUTPUT_DIR" || hard_fail "setup"
|
|
|
|
generate_and_compare() {
|
|
echo
|
|
echo "Testing $1 generation: $2 -> $3"
|
|
|
|
"$WAYLAND_SCANNER" $1 < "$TEST_DATA_DIR/$2" > "$TEST_OUTPUT_DIR/$3" || \
|
|
hard_fail "$2 -> $3"
|
|
|
|
"$SED" -i -e 's/Generated by wayland-scanner [0-9.]*/SCANNER TEST/' \
|
|
"$TEST_OUTPUT_DIR/$3" || hard_fail "$2 -> $3"
|
|
|
|
diff -q "$TEST_DATA_DIR/$3" "$TEST_OUTPUT_DIR/$3" && \
|
|
echo "$2 -> $3 PASS" || \
|
|
fail "$2 -> $3"
|
|
}
|
|
|
|
verify_error() {
|
|
echo
|
|
echo "Checking that reading $1 gives an error on line $3"
|
|
|
|
[ -f "$TEST_DATA_DIR/$1" ] || hard_fail "$1 not present"
|
|
|
|
# Confirm failure error code
|
|
"$WAYLAND_SCANNER" server-header < "$TEST_DATA_DIR/$1" >/dev/null 2>"$TEST_OUTPUT_DIR/$2" && \
|
|
fail "$1 return code check"
|
|
|
|
# Verify that an error is produced at the correct line
|
|
grep -q "<stdin>:$3: error:" "$TEST_OUTPUT_DIR/$2" && echo "$1 PASS" || fail "$1 line number check"
|
|
}
|
|
|
|
generate_and_compare "code" "example.xml" "example-code.c"
|
|
generate_and_compare "client-header" "example.xml" "example-client.h"
|
|
generate_and_compare "server-header" "example.xml" "example-server.h"
|
|
|
|
generate_and_compare "code" "small.xml" "small-code.c"
|
|
generate_and_compare "client-header" "small.xml" "small-client.h"
|
|
generate_and_compare "server-header" "small.xml" "small-server.h"
|
|
|
|
generate_and_compare "-c code" "small.xml" "small-code-core.c"
|
|
generate_and_compare "-c client-header" "small.xml" "small-client-core.h"
|
|
generate_and_compare "-c server-header" "small.xml" "small-server-core.h"
|
|
|
|
# The existing "code" must produce result identical to "public-code"
|
|
generate_and_compare "code" "small.xml" "small-code.c"
|
|
generate_and_compare "public-code" "small.xml" "small-code.c"
|
|
generate_and_compare "private-code" "small.xml" "small-private-code.c"
|
|
|
|
generate_and_compare "code" "empty.xml" "empty-code.c"
|
|
generate_and_compare "client-header" "empty.xml" "empty-client.h"
|
|
generate_and_compare "server-header" "empty.xml" "empty-server.h"
|
|
|
|
verify_error "bad-identifier-arg.xml" "bad-identifier-arg.log" 7
|
|
verify_error "bad-identifier-entry.xml" "bad-identifier-entry.log" 8
|
|
verify_error "bad-identifier-enum.xml" "bad-identifier-enum.log" 6
|
|
verify_error "bad-identifier-event.xml" "bad-identifier-event.log" 6
|
|
verify_error "bad-identifier-interface.xml" "bad-identifier-interface.log" 3
|
|
verify_error "bad-identifier-protocol.xml" "bad-identifier-protocol.log" 2
|
|
verify_error "bad-identifier-request.xml" "bad-identifier-request.log" 6
|
|
|
|
exit $RETCODE
|