mirror of
https://gitlab.freedesktop.org/wayland/wayland.git
synced 2025-11-01 22:58:40 -04:00
bf34ac75d0
When we are adding padding bytes making our wl_buffer buffer content 4 byte aligned, we are just moving the pointer. Since the buffer is allocated using plain malloc(), this means our padding bytes are effectively uninitialized data, which could be anything previously allocated in the server process. As we'll be sharing this buffer content with arbitrary clients, we are effectively sharing private memory with every client, and even though a well behaving client will discard any such memory, a malicious client may not. Therefor, to avoid any potential missuse of the uninitialized padding memory shared between the server and client, initialize the buffer content to 0, making the padding bytes always 0. Signed-off-by: Jonas Ådahl <jadahl@gmail.com> Reviewed-by: Derek Foreman <derekf@osg.samsung.com> Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk> Reviewed-by: Bryce Harrington <bryce@osg.samsung.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| connection.c | ||
| dtddata.S | ||
| event-loop.c | ||
| scanner.c | ||
| scanner.mk | ||
| wayland-client-core.h | ||
| wayland-client-uninstalled.pc.in | ||
| wayland-client.c | ||
| wayland-client.h | ||
| wayland-client.pc.in | ||
| wayland-egl-core.h | ||
| wayland-egl.h | ||
| wayland-os.c | ||
| wayland-os.h | ||
| wayland-private.h | ||
| wayland-scanner-uninstalled.pc.in | ||
| wayland-scanner.pc.in | ||
| wayland-server-core.h | ||
| wayland-server-uninstalled.pc.in | ||
| wayland-server.c | ||
| wayland-server.h | ||
| wayland-server.pc.in | ||
| wayland-shm.c | ||
| wayland-util.c | ||
| wayland-util.h | ||
| wayland-version.h.in | ||