mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-10-31 22:25:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

event-loop: Fix idle handler dispatch corner case

Browse source 
When the last idle handler queues another idle handler, we fail to
dispatch that last handler.  The wl_list_for_each_safe loop looks up
the next pointer before running the handler, and at that point it points
to the head of the list and the loop terminates.

Instead, just loop until the list is empty.
This commit is contained in:
Kristian Høgsberg 2011-10-29 14:27:33 -04:00
parent 7e57dc143e
commit f86338d611
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/event-loop.c
View file

@ -434,9 +434,11 @@ post_dispatch_check(struct wl_event_loop *loop)
static void
dispatch_idle_sources(struct wl_event_loop *loop)
{
struct wl_event_source_idle *source, *next;
struct wl_event_source_idle *source;
wl_list_for_each_safe(source, next, &loop->idle_list, base.link) {
while (!wl_list_empty(&loop->idle_list)) {
source = container_of(loop->idle_list.next,
struct wl_event_source_idle, base.link);
source->func(source->base.data);
wl_event_source_remove(&source->base);
}