mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-10-29 05:40:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: Add a test for fd leaks on zombie objects

Browse source 
Until recently, if a client destroying a resource raced with the
server generating an event on that resource that delivered a file
descriptor, we would leak the fd.

This tests for a leaked fd from that race condition.

Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Derek Foreman <derekf@osg.samsung.com>
This commit is contained in:
Derek Foreman 2017-12-06 11:22:24 -06:00 • committed by Daniel Stone
parent 239ba39331
commit f74c9b98db
3 changed files with 151 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

102
tests/display-test.c
View file

@ -47,6 +47,9 @@
#include "test-runner.h"
#include "test-compositor.h"
#include "tests-server-protocol.h"
#include "tests-client-protocol.h"
struct display_destroy_listener {
struct wl_listener listener;
int done;
@ -1066,3 +1069,102 @@ TEST(bind_fails_on_filtered_global)
display_destroy(d);
}
static void
pre_fd(void *data, struct fd_passer *fdp)
{
fd_passer_destroy(fdp);
}
static void
fd(void *data, struct fd_passer *fdp, int32_t fd)
{
/* We destroyed the resource before this event */
assert(false);
}
struct fd_passer_listener fd_passer_listener = {
pre_fd,
fd,
};
static void
zombie_fd_handle_globals(void *data, struct wl_registry *registry,
uint32_t id, const char *intf, uint32_t ver)
{
struct fd_passer *fdp;
if (!strcmp(intf, "fd_passer")) {
fdp = wl_registry_bind(registry, id, &fd_passer_interface, 1);
fd_passer_add_listener(fdp, &fd_passer_listener, NULL);
}
}
static const struct wl_registry_listener zombie_fd_registry_listener = {
zombie_fd_handle_globals,
NULL
};
static void
zombie_client(void *data)
{
struct client *c = client_connect();
struct wl_registry *registry;
registry = wl_display_get_registry(c->wl_display);
wl_registry_add_listener(registry, &zombie_fd_registry_listener, NULL);
/* Gets the registry */
wl_display_roundtrip(c->wl_display);
/* push out the fd_passer bind */
wl_display_roundtrip(c->wl_display);
/* push out our fd_passer.destroy */
wl_display_roundtrip(c->wl_display);
wl_registry_destroy(registry);
client_disconnect_nocheck(c);
}
static void
fd_passer_clobber(struct wl_client *client, struct wl_resource *res)
{
wl_resource_destroy(res);
}
static const struct fd_passer_interface fdp_interface = {
fd_passer_clobber,
};
static void
bind_fd_passer(struct wl_client *client, void *data,
uint32_t vers, uint32_t id)
{
struct wl_resource *res;
res = wl_resource_create(client, &fd_passer_interface, vers, id);
wl_resource_set_implementation(res, &fdp_interface, NULL, NULL);
assert(res);
fd_passer_send_pre_fd(res);
fd_passer_send_fd(res, fileno(stdin));
}
TEST(zombie_fd)
{
struct display *d;
struct wl_global *g;
d = display_create();
g = wl_global_create(d->wl_display, &fd_passer_interface,
1, d, bind_fd_passer);
client_create_noarg(d, zombie_client);
display_run(d);
wl_global_destroy(g);
display_destroy(d);
}