From eac3fd97e995787b9f2072cb4679d8bed30994c1 Mon Sep 17 00:00:00 2001 From: Julian Orth Date: Thu, 11 Dec 2025 22:48:21 +0100 Subject: [PATCH] protocol: remove note discouraging use of wl_surface.damage If a client tracks damage in surface coordinates, there is no reason for it to use the damage_buffer request. The message of the commit that originally added this note says that the compositor might implement wl_surface.damage inefficiently and that it is complicated to implement correctly. Having the logic replicated in every client that tracks damage in surface coordinates does not make it more efficient or more correct. The conversion between surface and buffer damage can be implemented as a matrix multiplication but it's not easy to get right and it is more likely that compositors will have a correct and fast implementation. Reverts: 921d0548035673a1bf6aeb9396b9bc728133411e Signed-off-by: Julian Orth --- protocol/wayland.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 5a6a189d..7eb9c13c 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1572,10 +1572,6 @@ wl_surface.commit assigns pending damage as the current damage, and clears pending damage. The server will clear the current damage as it repaints the surface. - - Note! New clients should not use this request. Instead damage can be - posted with wl_surface.damage_buffer which uses buffer coordinates - instead of surface coordinates.