mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2026-02-16 22:05:55 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

connection: Handle non-nullable strings in wl_connection_demarshal

Browse source 
Currently a null string passed into a non-nullable argument of a message
will decode succesfully, probably resulting in the handler function
crashing. Instead treat it the same way we do non-nullable objects and ids.

Signed-off-by: Fergus Dall <sidereal@google.com>
This commit is contained in:
Fergus Dall 2021-06-22 19:31:26 +10:00
parent 4f53613e70
commit ccc9612e82
2 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/connection.c
View file

@ -749,6 +749,13 @@ wl_connection_demarshal(struct wl_connection *connection,
case 's':
length = *p++;
if (length == 0 && !arg.nullable) {
wl_log("NULL string received on non-nullable "
"type, message %s(%s)\n", message->name,
message->signature);
errno = EINVAL;
goto err;
}
if (length == 0) {
closure->args[i].s = NULL;
break;