From b5f97895da4aae4ba87ae3aa7da36abb86dcb58c Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Tue, 3 Jul 2018 13:32:00 +0300 Subject: [PATCH] contributing: how to read the review rules This is to avoid fighting around the letter of the guidelines. This is not a protocol spec. Signed-off-by: Pekka Paalanen Reviewed-by: Daniel Stone Reviewed-by: Derek Foreman --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 70d0eca0..538613fc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -206,6 +206,11 @@ people with commit access, there needs to be at least one Acked-by from someone with commit access. A person with commit access is expected to be able to evaluate the patch with respect to the project scope and architecture. +The below review guidelines are intended to be interpreted in spirit, not by +the letter. There may be circumstances where some guidelines are better +ignored. We rely very much on the judgement of reviewers and commit rights +holders. + During review, the following matters should be checked: - The commit message explains why the change is being made.