mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-11-21 06:59:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

scanner: add validators for enums

Browse source 
Right now compositors need to manually check that enum values sent
by the client are valid. In particular:

- Check that the value sent by the client is not outside of the enum.
- Check that the version of the enum entry is consistent with the
  object version.

Automatically generate validator functions to perform these tasks.

Signed-off-by: Simon Ser <contact@emersion.fr>
Closes: https://gitlab.freedesktop.org/wayland/wayland/-/issues/104
This commit is contained in:
Simon Ser 2022-09-17 10:53:56 +02:00
parent 5eeaac6e11
commit b258d5f361
14 changed files with 720 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

31
tests/data/small-server.h
View file

@ -83,11 +83,42 @@ enum intf_A_foo {
* @since 2
*/
INTF_A_FOO_THIRD = 2,
/**
* this is a negative value
* @since 2
*/
INTF_A_FOO_NEGATIVE = -1,
};
/**
* @ingroup iface_intf_A
*/
#define INTF_A_FOO_THIRD_SINCE_VERSION 2
/**
* @ingroup iface_intf_A
*/
#define INTF_A_FOO_NEGATIVE_SINCE_VERSION 2
/**
* @ingroup iface_intf_A
* Validate a intf_A foo value.
*
* @return true on success, false on error.
* @ref intf_A_foo
*/
static inline bool
intf_A_foo_is_valid(uint32_t value, uint32_t version) {
switch (value) {
case INTF_A_FOO_FIRST:
return version >= 1;
case INTF_A_FOO_SECOND:
return version >= 1;
case INTF_A_FOO_THIRD:
return version >= 2;
case (uint32_t)INTF_A_FOO_NEGATIVE:
return version >= 2;
default:
return false;
}
}
#endif /* INTF_A_FOO_ENUM */
/**