mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-10-29 05:40:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

client: check event opcode in queue_event

Browse source 
If the client binds to a global with an interface mismatch, it may receive an
event from the server with an unknown opcode. See [1].

Instead of crashing, print a more useful debug message and close the connection.

[1]: https://gitlab.freedesktop.org/wayland/wayland/issues/113

Signed-off-by: Simon Ser <simon.ser@intel.com>
This commit is contained in:
Simon Ser 2019-08-28 17:11:21 +03:00 • committed by Pekka Paalanen
parent 152c9ed968
commit a277cc6d52
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/wayland-client.c
View file

@ -1364,6 +1364,12 @@ queue_event(struct wl_display *display, int len)
return size; return size;
} }
if (opcode >= proxy->object.interface->event_count) {
wl_log("interface '%s' has no event %u\n",
proxy->object.interface->name, opcode);
return -1;
}
message = &proxy->object.interface->events[opcode]; message = &proxy->object.interface->events[opcode];
closure = wl_connection_demarshal(display->connection, size, closure = wl_connection_demarshal(display->connection, size,
&display->objects, message); &display->objects, message);