cursor: rename local variables to snake case

Signed-off-by: Simon Ser <contact@emersion.fr>
This commit is contained in:
Simon Ser 2022-04-21 12:01:19 +02:00
parent cf9065dfb8
commit 93b61fde1f

View file

@ -266,34 +266,34 @@ xcursor_read_uint(FILE *file, uint32_t *u)
} }
static void static void
xcursor_file_header_destroy(struct xcursor_file_header *fileHeader) xcursor_file_header_destroy(struct xcursor_file_header *file_header)
{ {
free(fileHeader); free(file_header);
} }
static struct xcursor_file_header * static struct xcursor_file_header *
xcursor_file_header_create(uint32_t ntoc) xcursor_file_header_create(uint32_t ntoc)
{ {
struct xcursor_file_header *fileHeader; struct xcursor_file_header *file_header;
if (ntoc > 0x10000) if (ntoc > 0x10000)
return NULL; return NULL;
fileHeader = malloc(sizeof(struct xcursor_file_header) + file_header = malloc(sizeof(struct xcursor_file_header) +
ntoc * sizeof(struct xcursor_file_toc)); ntoc * sizeof(struct xcursor_file_toc));
if (!fileHeader) if (!file_header)
return NULL; return NULL;
fileHeader->magic = XCURSOR_MAGIC; file_header->magic = XCURSOR_MAGIC;
fileHeader->header = XCURSOR_FILE_HEADER_LEN; file_header->header = XCURSOR_FILE_HEADER_LEN;
fileHeader->version = XCURSOR_FILE_VERSION; file_header->version = XCURSOR_FILE_VERSION;
fileHeader->ntoc = ntoc; file_header->ntoc = ntoc;
fileHeader->tocs = (struct xcursor_file_toc *) (fileHeader + 1); file_header->tocs = (struct xcursor_file_toc *) (file_header + 1);
return fileHeader; return file_header;
} }
static struct xcursor_file_header * static struct xcursor_file_header *
xcursor_read_file_header(FILE *file) xcursor_read_file_header(FILE *file)
{ {
struct xcursor_file_header head, *fileHeader; struct xcursor_file_header head, *file_header;
uint32_t skip; uint32_t skip;
unsigned int n; unsigned int n;
@ -314,60 +314,60 @@ xcursor_read_file_header(FILE *file)
if (skip) if (skip)
if (fseek(file, skip, SEEK_CUR) == EOF) if (fseek(file, skip, SEEK_CUR) == EOF)
return NULL; return NULL;
fileHeader = xcursor_file_header_create(head.ntoc); file_header = xcursor_file_header_create(head.ntoc);
if (!fileHeader) if (!file_header)
return NULL; return NULL;
fileHeader->magic = head.magic; file_header->magic = head.magic;
fileHeader->header = head.header; file_header->header = head.header;
fileHeader->version = head.version; file_header->version = head.version;
fileHeader->ntoc = head.ntoc; file_header->ntoc = head.ntoc;
for (n = 0; n < fileHeader->ntoc; n++) { for (n = 0; n < file_header->ntoc; n++) {
if (!xcursor_read_uint(file, &fileHeader->tocs[n].type)) if (!xcursor_read_uint(file, &file_header->tocs[n].type))
break; break;
if (!xcursor_read_uint(file, &fileHeader->tocs[n].subtype)) if (!xcursor_read_uint(file, &file_header->tocs[n].subtype))
break; break;
if (!xcursor_read_uint(file, &fileHeader->tocs[n].position)) if (!xcursor_read_uint(file, &file_header->tocs[n].position))
break; break;
} }
if (n != fileHeader->ntoc) { if (n != file_header->ntoc) {
xcursor_file_header_destroy(fileHeader); xcursor_file_header_destroy(file_header);
return NULL; return NULL;
} }
return fileHeader; return file_header;
} }
static bool static bool
xcursor_seek_to_toc(FILE *file, xcursor_seek_to_toc(FILE *file,
struct xcursor_file_header *fileHeader, struct xcursor_file_header *file_header,
int toc) int toc)
{ {
if (!file || !fileHeader || if (!file || !file_header ||
fseek(file, fileHeader->tocs[toc].position, SEEK_SET) == EOF) fseek(file, file_header->tocs[toc].position, SEEK_SET) == EOF)
return false; return false;
return true; return true;
} }
static bool static bool
xcursor_file_read_chunk_header(FILE *file, xcursor_file_read_chunk_header(FILE *file,
struct xcursor_file_header *fileHeader, struct xcursor_file_header *file_header,
int toc, int toc,
struct xcursor_chunk_header *chunkHeader) struct xcursor_chunk_header *chunk_header)
{ {
if (!file || !fileHeader || !chunkHeader) if (!file || !file_header || !chunk_header)
return false; return false;
if (!xcursor_seek_to_toc(file, fileHeader, toc)) if (!xcursor_seek_to_toc(file, file_header, toc))
return false; return false;
if (!xcursor_read_uint(file, &chunkHeader->header)) if (!xcursor_read_uint(file, &chunk_header->header))
return false; return false;
if (!xcursor_read_uint(file, &chunkHeader->type)) if (!xcursor_read_uint(file, &chunk_header->type))
return false; return false;
if (!xcursor_read_uint(file, &chunkHeader->subtype)) if (!xcursor_read_uint(file, &chunk_header->subtype))
return false; return false;
if (!xcursor_read_uint(file, &chunkHeader->version)) if (!xcursor_read_uint(file, &chunk_header->version))
return false; return false;
/* sanity check */ /* sanity check */
if (chunkHeader->type != fileHeader->tocs[toc].type || if (chunk_header->type != file_header->tocs[toc].type ||
chunkHeader->subtype != fileHeader->tocs[toc].subtype) chunk_header->subtype != file_header->tocs[toc].subtype)
return false; return false;
return true; return true;
} }
@ -379,72 +379,72 @@ dist(uint32_t a, uint32_t b)
} }
static uint32_t static uint32_t
xcursor_file_best_size(struct xcursor_file_header *fileHeader, xcursor_file_best_size(struct xcursor_file_header *file_header,
uint32_t size, int *nsizesp) uint32_t size, int *nsizesp)
{ {
unsigned int n; unsigned int n;
int nsizes = 0; int nsizes = 0;
uint32_t bestSize = 0; uint32_t best_size = 0;
uint32_t thisSize; uint32_t this_size;
if (!fileHeader || !nsizesp) if (!file_header || !nsizesp)
return 0; return 0;
for (n = 0; n < fileHeader->ntoc; n++) { for (n = 0; n < file_header->ntoc; n++) {
if (fileHeader->tocs[n].type != XCURSOR_IMAGE_TYPE) if (file_header->tocs[n].type != XCURSOR_IMAGE_TYPE)
continue; continue;
thisSize = fileHeader->tocs[n].subtype; this_size = file_header->tocs[n].subtype;
if (!bestSize || dist(thisSize, size) < dist(bestSize, size)) { if (!best_size || dist(this_size, size) < dist(best_size, size)) {
bestSize = thisSize; best_size = this_size;
nsizes = 1; nsizes = 1;
} else if (thisSize == bestSize) { } else if (this_size == best_size) {
nsizes++; nsizes++;
} }
} }
*nsizesp = nsizes; *nsizesp = nsizes;
return bestSize; return best_size;
} }
static int static int
xcursor_find_image_toc(struct xcursor_file_header *fileHeader, xcursor_find_image_toc(struct xcursor_file_header *file_header,
uint32_t size, int count) uint32_t size, int count)
{ {
unsigned int toc; unsigned int toc;
uint32_t thisSize; uint32_t this_size;
if (!fileHeader) if (!file_header)
return 0; return 0;
for (toc = 0; toc < fileHeader->ntoc; toc++) { for (toc = 0; toc < file_header->ntoc; toc++) {
if (fileHeader->tocs[toc].type != XCURSOR_IMAGE_TYPE) if (file_header->tocs[toc].type != XCURSOR_IMAGE_TYPE)
continue; continue;
thisSize = fileHeader->tocs[toc].subtype; this_size = file_header->tocs[toc].subtype;
if (thisSize != size) if (this_size != size)
continue; continue;
if (!count) if (!count)
break; break;
count--; count--;
} }
if (toc == fileHeader->ntoc) if (toc == file_header->ntoc)
return -1; return -1;
return toc; return toc;
} }
static struct xcursor_image * static struct xcursor_image *
xcursor_read_image(FILE *file, xcursor_read_image(FILE *file,
struct xcursor_file_header *fileHeader, struct xcursor_file_header *file_header,
int toc) int toc)
{ {
struct xcursor_chunk_header chunkHeader; struct xcursor_chunk_header chunk_header;
struct xcursor_image head; struct xcursor_image head;
struct xcursor_image *image; struct xcursor_image *image;
int n; int n;
uint32_t *p; uint32_t *p;
if (!file || !fileHeader) if (!file || !file_header)
return NULL; return NULL;
if (!xcursor_file_read_chunk_header(file, fileHeader, toc, &chunkHeader)) if (!xcursor_file_read_chunk_header(file, file_header, toc, &chunk_header))
return NULL; return NULL;
if (!xcursor_read_uint(file, &head.width)) if (!xcursor_read_uint(file, &head.width))
return NULL; return NULL;
@ -469,9 +469,9 @@ xcursor_read_image(FILE *file,
image = xcursor_image_create(head.width, head.height); image = xcursor_image_create(head.width, head.height);
if (image == NULL) if (image == NULL)
return NULL; return NULL;
if (chunkHeader.version < image->version) if (chunk_header.version < image->version)
image->version = chunkHeader.version; image->version = chunk_header.version;
image->size = chunkHeader.subtype; image->size = chunk_header.subtype;
image->xhot = head.xhot; image->xhot = head.xhot;
image->yhot = head.yhot; image->yhot = head.yhot;
image->delay = head.delay; image->delay = head.delay;
@ -490,8 +490,8 @@ xcursor_read_image(FILE *file,
static struct xcursor_images * static struct xcursor_images *
xcursor_xc_file_load_images(FILE *file, int size) xcursor_xc_file_load_images(FILE *file, int size)
{ {
struct xcursor_file_header *fileHeader; struct xcursor_file_header *file_header;
uint32_t bestSize; uint32_t best_size;
int nsize; int nsize;
struct xcursor_images *images; struct xcursor_images *images;
int n; int n;
@ -499,30 +499,30 @@ xcursor_xc_file_load_images(FILE *file, int size)
if (!file || size < 0) if (!file || size < 0)
return NULL; return NULL;
fileHeader = xcursor_read_file_header(file); file_header = xcursor_read_file_header(file);
if (!fileHeader) if (!file_header)
return NULL; return NULL;
bestSize = xcursor_file_best_size(fileHeader, (uint32_t) size, &nsize); best_size = xcursor_file_best_size(file_header, (uint32_t) size, &nsize);
if (!bestSize) { if (!best_size) {
xcursor_file_header_destroy(fileHeader); xcursor_file_header_destroy(file_header);
return NULL; return NULL;
} }
images = xcursor_images_create(nsize); images = xcursor_images_create(nsize);
if (!images) { if (!images) {
xcursor_file_header_destroy(fileHeader); xcursor_file_header_destroy(file_header);
return NULL; return NULL;
} }
for (n = 0; n < nsize; n++) { for (n = 0; n < nsize; n++) {
toc = xcursor_find_image_toc(fileHeader, bestSize, n); toc = xcursor_find_image_toc(file_header, best_size, n);
if (toc < 0) if (toc < 0)
break; break;
images->images[images->nimage] = xcursor_read_image(file, fileHeader, images->images[images->nimage] = xcursor_read_image(file, file_header,
toc); toc);
if (!images->images[images->nimage]) if (!images->images[images->nimage])
break; break;
images->nimage++; images->nimage++;
} }
xcursor_file_header_destroy(fileHeader); xcursor_file_header_destroy(file_header);
if (images->nimage != nsize) { if (images->nimage != nsize) {
xcursor_images_destroy(images); xcursor_images_destroy(images);
images = NULL; images = NULL;