From 8bc42fbf7bb53f4942c50be10be572ee479bab0f Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Thu, 5 Nov 2015 13:57:47 -0600 Subject: [PATCH] shm: wl_shm_buffer_get_data() requires a valid pool. There's no situation where a shm buffer without a pool makes sense, so we enforce the pool's existence a little more rigidly. Acked-by: Pekka Paalanen Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo --- src/wayland-shm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index db239095..0cd8c118 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -353,10 +353,12 @@ wl_shm_buffer_get_stride(struct wl_shm_buffer *buffer) WL_EXPORT void * wl_shm_buffer_get_data(struct wl_shm_buffer *buffer) { - if (buffer->pool) - return buffer->pool->data + buffer->offset; - else - return buffer + 1; + assert(buffer->pool); + + if (!buffer->pool) + return NULL; + + return buffer->pool->data + buffer->offset; } WL_EXPORT uint32_t